feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Replace QFile::exists by QFileInfo::exists

Browse Source 
QFile::exists only calls QFileInfo::exists, so this saves one
function call per invocation.

Change-Id: I41cb407345654eeead14455a4955b8b9b015aedc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-09-01 11:23:56 +02:00
parent 3d028125df
commit 9679412a23
40 changed files with 53 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/coreplugin/editormanager/editorview.cpp
View File

@@ -957,7 +957,7 @@ void SplitterOrView::restoreState(const QByteArray &state)
stream >> historyData;
view()->m_editorHistory = loadHistory(historyData);
if (!QFile::exists(fileName))
if (!QFileInfo::exists(fileName))
return;
IEditor *e = EditorManagerPrivate::openEditor(view(), FilePath::fromString(fileName), Id::fromString(id),
EditorManager::IgnoreNavigationHistory

2
src/plugins/coreplugin/generalsettings.cpp
View File

@@ -174,7 +174,7 @@ static bool hasQmFilesForLocale(const QString &locale, const QString &creatorTrP
static const QString qtTrPath = QLibraryInfo::path(QLibraryInfo::TranslationsPath);
const QString trFile = QLatin1String("/qt_") + locale + QLatin1String(".qm");
return QFile::exists(qtTrPath + trFile) || QFile::exists(creatorTrPath + trFile);
return QFileInfo::exists(qtTrPath + trFile) || QFileInfo::exists(creatorTrPath + trFile);
}
void GeneralSettingsWidget::fillLanguageBox() const

2
src/plugins/coreplugin/mimetypesettings.cpp
View File

@@ -633,7 +633,7 @@ void MimeTypeSettingsPrivate::writeUserModifiedMimeTypes()
{
static Utils::FilePath modifiedMimeTypesFile = ICore::userResourcePath(kModifiedMimeTypesFile);
if (QFile::exists(modifiedMimeTypesFile.toString())
if (QFileInfo::exists(modifiedMimeTypesFile.toString())
|| QDir().mkpath(modifiedMimeTypesFile.parentDir().toString())) {
QFile file(modifiedMimeTypesFile.toString());
if (file.open(QFile::WriteOnly | QFile::Truncate)) {

2
src/plugins/coreplugin/plugininstallwizard.cpp
View File

@@ -109,7 +109,7 @@ public:
bool isComplete() const final
{
const FilePath path = m_data->sourcePath;
if (!QFile::exists(path.toString())) {
if (!QFileInfo::exists(path.toString())) {
m_info->setText(Tr::tr("File does not exist."));
return false;
}