From 96c5a8a789d0fc24696e8f893261f476c120d412 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 5 Jul 2022 13:07:37 +0200 Subject: [PATCH] PipSupport: Connect to watcher before setting a future In order to avoid runtime warning: "QFutureWatcher::connect: connecting after calling setFuture() is likely to produce race". Change-Id: I921396628e5615e7c2d87045d2e787388dbddcc6 Reviewed-by: David Schulz --- src/plugins/python/pipsupport.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/plugins/python/pipsupport.cpp b/src/plugins/python/pipsupport.cpp index b290f75d2ee..3d479f871ba 100644 --- a/src/plugins/python/pipsupport.cpp +++ b/src/plugins/python/pipsupport.cpp @@ -50,13 +50,12 @@ static constexpr char pipInstallTaskId[] = "Python::pipInstallTask"; PipInstallTask::PipInstallTask(const FilePath &python) : m_python(python) { - m_watcher.setFuture(m_future.future()); - connect(&m_process, &QtcProcess::done, this, &PipInstallTask::handleDone); connect(&m_process, &QtcProcess::readyReadStandardError, this, &PipInstallTask::handleError); connect(&m_process, &QtcProcess::readyReadStandardOutput, this, &PipInstallTask::handleOutput); connect(&m_killTimer, &QTimer::timeout, this, &PipInstallTask::cancel); connect(&m_watcher, &QFutureWatcher::canceled, this, &PipInstallTask::cancel); + m_watcher.setFuture(m_future.future()); } void PipInstallTask::setPackage(const PipPackage &package)