From 96ea9e38913dc4b418f1ef29792e7aa7704f5eeb Mon Sep 17 00:00:00 2001 From: Marco Bubke Date: Mon, 13 Feb 2023 13:31:10 +0100 Subject: [PATCH] QmlDesigner: Stop on every warning We already had some bugs because warnings were ignored. So we generate errors now for the qml desinger plugins. Task-number: QDS-9135 Change-Id: I9276a1b5cdbec554bc33c0c6ed3706817518f39c Reviewed-by: Tim Jenssen --- src/plugins/qmldesigner/CMakeLists.txt | 2 ++ src/plugins/qmldesignerbase/CMakeLists.txt | 1 + src/plugins/qmlprojectmanager/CMakeLists.txt | 1 + 3 files changed, 4 insertions(+) diff --git a/src/plugins/qmldesigner/CMakeLists.txt b/src/plugins/qmldesigner/CMakeLists.txt index f7024e4dd55..cda9c8a96c6 100644 --- a/src/plugins/qmldesigner/CMakeLists.txt +++ b/src/plugins/qmldesigner/CMakeLists.txt @@ -11,6 +11,7 @@ option(USE_PROJECTSTORAGE "Use ProjectStorage" ${ENV_QDS_USE_PROJECTSTORAGE}) add_feature_info("ProjectStorage" ${USE_PROJECTSTORAGE} "") add_qtc_library(QmlDesignerUtils STATIC + PROPERTIES COMPILE_WARNING_AS_ERROR ON DEPENDS Qt::Gui Utils Qt::QmlPrivate DEFINES QMLDESIGNERUTILS_LIBRARY @@ -405,6 +406,7 @@ set_property(SOURCE ${PROJECTSTORAGE_EXCLUDED_SOURCES} PROPERTY SKIP_AUTOMOC ON) add_qtc_plugin(QmlDesigner CONDITION Qt6_VERSION VERSION_GREATER_EQUAL 6.2.0 AND TARGET Qt::QuickWidgets AND TARGET Qt::Svg + PROPERTIES COMPILE_WARNING_AS_ERROR ON DEPENDS QmlJS LanguageUtils QmlEditorWidgets AdvancedDockingSystem Qt::QuickWidgets Qt::CorePrivate Sqlite Qt::Xml Qt::Svg diff --git a/src/plugins/qmldesignerbase/CMakeLists.txt b/src/plugins/qmldesignerbase/CMakeLists.txt index fa7f63d5a94..f03498f28d9 100644 --- a/src/plugins/qmldesignerbase/CMakeLists.txt +++ b/src/plugins/qmldesignerbase/CMakeLists.txt @@ -1,4 +1,5 @@ add_qtc_plugin(QmlDesignerBase + PROPERTIES COMPILE_WARNING_AS_ERROR ON DEPENDS Qt::Core Qt::QuickWidgets PLUGIN_DEPENDS Core ProjectExplorer QtSupport SOURCES diff --git a/src/plugins/qmlprojectmanager/CMakeLists.txt b/src/plugins/qmlprojectmanager/CMakeLists.txt index 5ecc763ef73..dfa38125ee1 100644 --- a/src/plugins/qmlprojectmanager/CMakeLists.txt +++ b/src/plugins/qmlprojectmanager/CMakeLists.txt @@ -1,5 +1,6 @@ add_qtc_plugin(QmlProjectManager CONDITION TARGET Qt5::QuickWidgets + PROPERTIES COMPILE_WARNING_AS_ERROR ON PLUGIN_CLASS QmlProjectPlugin DEPENDS QmlJS Qt5::QuickWidgets PLUGIN_DEPENDS Core ProjectExplorer QtSupport QmlDesignerBase