From 973cabd5c5c6a18f0f9d396be6c13bb0170fb843 Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Mon, 8 Feb 2016 12:27:28 +0300 Subject: [PATCH] qmake: de-duplicate QString::number() calls with same arg Change-Id: I6e05b9ad3350bd0da5b8a6dc1389ae05315a33df Reviewed-by: Marc Mutz (cherry picked from qtbase/27de4ea4d672d9f1b3a733f803f8605f81311d0a) Reviewed-by: Anton Kudryavtsev --- src/shared/proparser/qmakebuiltins.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/shared/proparser/qmakebuiltins.cpp b/src/shared/proparser/qmakebuiltins.cpp index 203597aed44..da860a8db85 100644 --- a/src/shared/proparser/qmakebuiltins.cpp +++ b/src/shared/proparser/qmakebuiltins.cpp @@ -299,8 +299,9 @@ static void addJsonArray(const QJsonArray &array, const QString &keyPrefix, ProV const int size = array.count(); keys.reserve(size); for (int i = 0; i < size; ++i) { - keys.append(QString::number(i)); - addJsonValue(array.at(i), keyPrefix + QString::number(i), map); + const QString number = QString::number(i); + keys.append(number); + addJsonValue(array.at(i), keyPrefix + number, map); } insertJsonKeyValue(keyPrefix + QLatin1String("_KEYS_"), keys, map); }