feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

class wizards: Do not qualify constructors with explicit, do not use "virtual".

Browse Source 
Again, consistency with other existing code generators. explicit is only useful
for libraries and confuses new users. virtual is not repeated for subclasses in
Qt.
by other generators either.
This commit is contained in:
Daniel Molkentin
2009-06-09 15:52:58 +02:00
parent e5ec0645c3
commit 97717b60e6
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/designer/cpp/formclasswizardparameters.cpp
View File

@@ -115,13 +115,13 @@ bool FormClassWizardParameters::generateCpp(QString *header, QString *source, in
}
headerStr << " {\n" << namespaceIndent << indent << "Q_OBJECT\n"
<< namespaceIndent << "public:\n"
<< namespaceIndent << indent << "explicit " << unqualifiedClassName << "(QWidget *parent = 0);\n";
<< namespaceIndent << indent << unqualifiedClassName << "(QWidget *parent = 0);\n";
if (embedding == PointerAggregatedUiClass)
headerStr << namespaceIndent << indent << "virtual ~" << unqualifiedClassName << "();\n";
headerStr << namespaceIndent << indent << "~" << unqualifiedClassName << "();\n";
// retranslation
if (languageChange)
headerStr << '\n' << namespaceIndent << "protected:\n"
<< namespaceIndent << indent << "virtual void changeEvent(QEvent *e);\n";
<< namespaceIndent << indent << "void changeEvent(QEvent *e);\n";
// Member variable
if (embedding != InheritedUiClass) {
headerStr << '\n' << namespaceIndent << "private:\n"