feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove BuildStepConfigWidget

Browse Source 
After the previous changes it was only an empty wrapper around QWidget.

Change-Id: I58dcd82d8342c7de5e2df537044f6cf3de878a67
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-10-02 17:53:39 +02:00
parent 2092ebd074
commit 97c6c13dcb
28 changed files with 52 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/ios/iosbuildstep.cpp
View File

@@ -69,7 +69,7 @@ public:
IosBuildStep(BuildStepList *stepList, Utils::Id id);
private:
BuildStepConfigWidget *createConfigWidget() final;
QWidget *createConfigWidget() final;
void setBaseArguments(const QStringList &args);
void setExtraArguments(const QStringList &extraArgs);
QStringList baseArguments() const;
@@ -88,9 +88,9 @@ private:
bool m_useDefaultArguments = true;
};
BuildStepConfigWidget *IosBuildStep::createConfigWidget()
QWidget *IosBuildStep::createConfigWidget()
{
auto widget = new BuildStepConfigWidget(this);
auto widget = new QWidget;
auto buildArgumentsLabel = new QLabel(tr("Base arguments:"), widget);

6
src/plugins/ios/iosdeploystep.cpp
View File

@@ -83,7 +83,7 @@ private:
void updateDisplayNames();
bool init() final;
BuildStepConfigWidget *createConfigWidget() final;
QWidget *createConfigWidget() final;
IDevice::ConstPtr device() const;
IosDevice::ConstPtr iosdevice() const;
IosSimulator::ConstPtr iossimulator() const;
@@ -230,9 +230,9 @@ void IosDeployStep::handleErrorMsg(IosToolHandler *handler, const QString &msg)
emit addOutput(msg, OutputFormat::ErrorMessage);
}
BuildStepConfigWidget *IosDeployStep::createConfigWidget()
QWidget *IosDeployStep::createConfigWidget()
{
auto widget = new BuildStepConfigWidget(this);
auto widget = new QWidget;
widget->setObjectName("IosDeployStepWidget");
setDisplayName(QString("<b>%1</b>").arg(displayName()));

4
src/plugins/ios/iosdsymbuildstep.cpp
View File

@@ -203,9 +203,9 @@ QStringList IosDsymBuildStep::arguments() const
}
BuildStepConfigWidget *IosDsymBuildStep::createConfigWidget()
QWidget *IosDsymBuildStep::createConfigWidget()
{
auto widget = new BuildStepConfigWidget(this);
auto widget = new QWidget;
auto commandLabel = new QLabel(tr("Command:"), widget);

2
src/plugins/ios/iosdsymbuildstep.h
View File

@@ -39,7 +39,7 @@ class IosDsymBuildStep : public ProjectExplorer::AbstractProcessStep
public:
IosDsymBuildStep(ProjectExplorer::BuildStepList *parent, Utils::Id id);
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
QWidget *createConfigWidget() override;
void setArguments(const QStringList &args);
QStringList arguments() const;
QStringList defaultArguments() const;