Vcs: Make submit editor setup a bit more compact

Change-Id: I14c4c51a456f7b3b04b79b63b476f89eb58d3ea0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2024-02-07 08:03:26 +01:00
parent 941ad80d60
commit 980605ecb0
11 changed files with 118 additions and 158 deletions

View File

@@ -93,13 +93,6 @@ const VcsBaseEditorParameters diffEditorParameters {
Constants::DIFFAPP
};
const VcsBaseSubmitEditorParameters submitEditorParameters {
Constants::COMMITMIMETYPE,
Constants::COMMIT_ID,
Constants::COMMIT_DISPLAY_NAME,
VcsBaseSubmitEditorParameters::DiffFiles
};
class MercurialPluginPrivate final : public VcsBase::VersionControlBase
{
public:
@@ -191,12 +184,6 @@ private:
FilePath m_submitRepository;
public:
VcsSubmitEditorFactory submitEditorFactory {
submitEditorParameters,
[] { return new CommitEditor; },
this
};
VcsEditorFactory logEditorFactory {
&logEditorParameters,
[this] { return new MercurialEditorWidget(&m_client); },
@@ -223,6 +210,14 @@ MercurialPluginPrivate::MercurialPluginPrivate()
{
dd = this;
setupVcsSubmitEditor(this, {
Constants::COMMITMIMETYPE,
Constants::COMMIT_ID,
Constants::COMMIT_DISPLAY_NAME,
VcsBaseSubmitEditorParameters::DiffFiles,
[] { return new CommitEditor; }
});
setTopicCache(new MercurialTopicCache(&m_client));
Core::Context context(Constants::MERCURIAL_CONTEXT);