Vcs: Make submit editor setup a bit more compact

Change-Id: I14c4c51a456f7b3b04b79b63b476f89eb58d3ea0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/perforce/perforceplugin.cpp

@@ -130,13 +130,6 @@ struct PerforceResponse
     QString stdErr;
 };
 
-const VcsBaseSubmitEditorParameters submitEditorParameters {
-    SUBMIT_MIMETYPE,
-    PERFORCE_SUBMIT_EDITOR_ID,
-    PERFORCE_SUBMIT_EDITOR_DISPLAY_NAME,
-    VcsBaseSubmitEditorParameters::DiffFiles
-};
-
 const VcsBaseEditorParameters logEditorParameters {
     LogOutput,
     PERFORCE_LOG_EDITOR_ID,
@@ -333,12 +326,6 @@ public:
 
     ManagedDirectoryCache m_managedDirectoryCache;
 
-    VcsSubmitEditorFactory submitEditorFactory {
-        submitEditorParameters,
-        [] { return new PerforceSubmitEditor; },
-        this
-    };
-
     VcsEditorFactory logEditorFactory {
         &logEditorParameters,
         [] { return new PerforceEditorWidget; },
@@ -367,6 +354,14 @@ PerforcePluginPrivate::PerforcePluginPrivate()
 
     dd = this;
 
+    setupVcsSubmitEditor(this, {
+        SUBMIT_MIMETYPE,
+        PERFORCE_SUBMIT_EDITOR_ID,
+        PERFORCE_SUBMIT_EDITOR_DISPLAY_NAME,
+        VcsBaseSubmitEditorParameters::DiffFiles,
+        [] { return new PerforceSubmitEditor; },
+    });
+
     const QString prefix = QLatin1String("p4");
     m_commandLocator = new CommandLocator("Perforce", prefix, prefix, this);
     m_commandLocator->setDescription(Tr::tr("Triggers a Perforce version control operation."));