From 989b44d911ecd68ba4ecd07fc6bd9faac2cb6853 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 24 Feb 2020 11:18:18 +0100 Subject: [PATCH] VcsBase: Don't use QObject inheritance in VcsEditorFactory The only remaining use is a setProperty that's never read back anymore after 9c96a1c4d. Change-Id: I2c49b044bb97a123e72070df5e83909c53e40881 Reviewed-by: Orgad Shaneh --- src/plugins/vcsbase/basevcseditorfactory.cpp | 1 - src/plugins/vcsbase/basevcseditorfactory.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/plugins/vcsbase/basevcseditorfactory.cpp b/src/plugins/vcsbase/basevcseditorfactory.cpp index 12f467afa05..8f25813885b 100644 --- a/src/plugins/vcsbase/basevcseditorfactory.cpp +++ b/src/plugins/vcsbase/basevcseditorfactory.cpp @@ -54,7 +54,6 @@ VcsEditorFactory::VcsEditorFactory(const VcsBaseEditorParameters *parameters, const EditorWidgetCreator editorWidgetCreator, std::function describeFunc) { - setProperty("VcsEditorFactoryName", QByteArray(parameters->id)); setId(parameters->id); setDisplayName(QCoreApplication::translate("VCS", parameters->displayName)); if (QLatin1String(parameters->mimeType) != QLatin1String(DiffEditor::Constants::DIFF_EDITOR_MIMETYPE)) diff --git a/src/plugins/vcsbase/basevcseditorfactory.h b/src/plugins/vcsbase/basevcseditorfactory.h index b1b828716e5..0afddcd5ce7 100644 --- a/src/plugins/vcsbase/basevcseditorfactory.h +++ b/src/plugins/vcsbase/basevcseditorfactory.h @@ -37,8 +37,6 @@ class VcsBaseEditorParameters; class VCSBASE_EXPORT VcsEditorFactory : public TextEditor::TextEditorFactory { - Q_OBJECT - public: VcsEditorFactory(const VcsBaseEditorParameters *parameters, const EditorWidgetCreator editorWidgetCreator,