From 98a649ccfd96e542b05024e67e4af82f7cd1d60f Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 21 Oct 2020 20:35:46 +0200 Subject: [PATCH] Fix crash for missing BuildSystem There is no gurantee that a Target has a BuildSystem. Target::additionalData() does expect a BuildSystem. Task-number: QTCREATORBUG-24817 Change-Id: I41edf89fa6dbf6ed24a27129b8353a9506b7b176 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/target.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/target.cpp b/src/plugins/projectexplorer/target.cpp index 5d253eb0977..3e83ae80867 100644 --- a/src/plugins/projectexplorer/target.cpp +++ b/src/plugins/projectexplorer/target.cpp @@ -775,7 +775,10 @@ void Target::setNamedSettings(const QString &name, const QVariant &value) QVariant Target::additionalData(Utils::Id id) const { - return buildSystem()->additionalData(id); + if (const BuildSystem *bs = buildSystem()) + return bs->additionalData(id); + + return {}; } MakeInstallCommand Target::makeInstallCommand(const QString &installRoot) const