From 98a9dcfeea70fd51ce40a0553fa6067a2237b559 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Wed, 23 Feb 2022 13:21:39 +0100 Subject: [PATCH] LanguageClient: show snippets only completion proposals again This reverts commit 5f1e6b15bf6d2af24ab4b5b500e6ba36a79600e7. We already prevent inserting snippets in some unwanted contexts in ClangdCompletionAssistProvider::createProcessor. Fixes: QTCREATORBUG-27051 Change-Id: I292d2816b366df6f0d0b070b7d732c199742fc7e Reviewed-by: Reviewed-by: Christian Kandeler --- src/plugins/languageclient/languageclientcompletionassist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/languageclient/languageclientcompletionassist.cpp b/src/plugins/languageclient/languageclientcompletionassist.cpp index bce818f96a9..3cec5a2e491 100644 --- a/src/plugins/languageclient/languageclientcompletionassist.cpp +++ b/src/plugins/languageclient/languageclientcompletionassist.cpp @@ -427,7 +427,7 @@ void LanguageClientCompletionAssistProcessor::handleCompletionResponse( items = Utils::get>(*result); } auto proposalItems = generateCompletionItems(items); - if (!proposalItems.isEmpty() && !m_snippetsGroup.isEmpty()) { + if (!m_snippetsGroup.isEmpty()) { proposalItems << TextEditor::SnippetAssistCollector( m_snippetsGroup, QIcon(":/texteditor/images/snippet.png")).collect(); }