From 98cc93b027716ee2bdeb26a20928e51f5576fcba Mon Sep 17 00:00:00 2001 From: Rainer Keller Date: Mon, 17 Oct 2022 10:28:20 +0200 Subject: [PATCH] McuSupport: Iterate over target packages directly The previous code iterates over all packages filtering out every package that is not in the list of the target. Instead, the list of target packages can be iterated directly. Change-Id: I03c9b86b45acca121abe6f2098d6c0e98fc94688 Reviewed-by: Daniele Bortolotti Reviewed-by: Reviewed-by: hjk --- src/plugins/mcusupport/mcusupportoptionspage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/mcusupport/mcusupportoptionspage.cpp b/src/plugins/mcusupport/mcusupportoptionspage.cpp index 4258b816d2d..fd166245a7f 100644 --- a/src/plugins/mcusupport/mcusupportoptionspage.cpp +++ b/src/plugins/mcusupport/mcusupportoptionspage.cpp @@ -254,8 +254,8 @@ void McuSupportOptionsWidget::showMcuTargetPackages() m_packagesLayout->removeRow(0); } - for (const auto &package : std::as_const(m_options.sdkRepository.packages)) { - if (!mcuTarget->packages().contains(package) || package->label().isEmpty()) + for (const auto &package : mcuTarget->packages()) { + if (package->label().isEmpty()) continue; QWidget *packageWidget = package->widget(); m_packagesLayout->addRow(package->label(), packageWidget);