feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: don't remove corefiles that we did not create.

Browse Source
This commit is contained in:
hjk
2010-09-07 14:19:44 +02:00
parent a364b93577
commit 98e37b3b15
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/debugger/debuggerengine.cpp
View File

@@ -108,6 +108,7 @@ using namespace TextEditor;
DebuggerStartParameters::DebuggerStartParameters()
: attachPID(-1),
useTerminal(false),
isSnapshot(false),
breakAtMain(false),
qmlServerAddress("127.0.0.1"),
qmlServerPort(0),

1
src/plugins/debugger/debuggerengine.h
View File

@@ -68,6 +68,7 @@ public:
QString executable;
QString displayName;
QString coreFile;
bool isSnapshot; // set if created internally
QStringList processArgs;
QStringList environment;
QString workingDirectory;

1
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -3022,6 +3022,7 @@ void GdbEngine::handleMakeSnapshot(const GdbResponse &response)
function = frame.function + _(":") + QString::number(frame.line);
}
sp.displayName = function + _(": ") + QDateTime::currentDateTime().toString();
sp.isSnapshot = true;
DebuggerRunControl *rc = DebuggerPlugin::createDebugger(sp);
DebuggerPlugin::startDebugger(rc);
} else {

10
src/plugins/debugger/snapshothandler.cpp
View File

@@ -127,9 +127,9 @@ SnapshotHandler::~SnapshotHandler()
{
for (int i = m_snapshots.size(); --i >= 0; ) {
if (DebuggerEngine *engine = engineAt(i)) {
QString fileName = engine->startParameters().coreFile;
if (!fileName.isEmpty())
QFile::remove(fileName);
const DebuggerStartParameters & sp = engine->startParameters();
if (sp.isSnapshot && !sp.coreFile.isEmpty())
QFile::remove(sp.coreFile);
}
}
}
@@ -270,8 +270,8 @@ void SnapshotHandler::removeSnapshot(int index)
const DebuggerEngine *engine = engineAt(index);
QTC_ASSERT(engine, return);
QString fileName = engine->startParameters().coreFile;
if (!fileName.isEmpty())
QFile::remove(fileName);
//if (!fileName.isEmpty())
// QFile::remove(fileName);
m_snapshots.removeAt(index);
if (index == m_currentIndex)
m_currentIndex = -1;