feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS tooltips: Avoid unhelpful tooltips.

Browse Source 
Saying 'unknown' or 'undefined' isn't very useful.

Change-Id: I130013a8f025ebc5eb984358f269fdf8a23aae92
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
This commit is contained in:
Christian Kamm
2011-10-25 12:11:45 +02:00
parent d48087d13d
commit 9902ed2bc9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmljseditor/qmljshoverhandler.cpp
View File

@@ -305,11 +305,12 @@ void HoverHandler::prettyPrintTooltip(const QmlJS::Value *value,
} }
if (toolTip().isEmpty()) { if (toolTip().isEmpty()) {
QString typeId = context->valueOwner()->typeId(value); if (!value->asUndefinedValue() && !value->asUnknownValue()) {
if (typeId != QLatin1String("undefined")) const QString typeId = context->valueOwner()->typeId(value);
setToolTip(typeId); setToolTip(typeId);
} }
} }
}
// if node refers to a property, its name and defining object are returned - otherwise zero // if node refers to a property, its name and defining object are returned - otherwise zero
static const ObjectValue *isMember(const ScopeChain &scopeChain, static const ObjectValue *isMember(const ScopeChain &scopeChain,