From 991663d13b2e3460d64a9aefcadc1be2a1812680 Mon Sep 17 00:00:00 2001 From: Vikas Pachdha Date: Mon, 11 Sep 2017 14:21:17 +0200 Subject: [PATCH] Android: Fix empty output when sdkmanager command fails Change-Id: I013f35880acd5683f23de49cb388c5ef9d8fc911 Reviewed-by: BogDan Vatra --- src/plugins/android/androidsdkmanager.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/plugins/android/androidsdkmanager.cpp b/src/plugins/android/androidsdkmanager.cpp index c28fef27a18..ee4f14ae93b 100644 --- a/src/plugins/android/androidsdkmanager.cpp +++ b/src/plugins/android/androidsdkmanager.cpp @@ -82,12 +82,9 @@ static bool sdkManagerCommand(const AndroidConfig config, const QStringList &arg proc.setTimeoutS(timeout); proc.setTimeOutMessageBoxEnabled(true); SynchronousProcessResponse response = proc.run(sdkManagerToolPath, args); - if (response.result == SynchronousProcessResponse::Finished) { - if (output) - *output = response.allOutput(); - return true; - } - return false; + if (output) + *output = response.allOutput(); + return response.result == SynchronousProcessResponse::Finished; } /*!