feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Avoid repetitive calls

Browse Source 
Change-Id: Iaf84cccf864b3975e6f6fe282a97fb5ea70e7a93
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-19 23:35:38 +03:00
committed by Orgad Shaneh
parent f470db1e23
commit 995cb365c4
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/qmlprofiler/qv8profilereventview.cpp
View File

@@ -469,11 +469,12 @@ void QV8ProfilerEventsMainView::QV8ProfilerEventsMainViewPrivate::buildV8ModelFr
item->setEditable(false); item->setEditable(false);
// metadata // metadata
newRow.at(0)->setData(QString::fromLatin1("%1:%2").arg(v8event->filename, QString::number(v8event->line)), EventHashStrRole); QStandardItem *firstItem = newRow.at(0);
newRow.at(0)->setData(QVariant(v8event->filename), FilenameRole); firstItem->setData(QString::fromLatin1("%1:%2").arg(v8event->filename, QString::number(v8event->line)), EventHashStrRole);
newRow.at(0)->setData(QVariant(v8event->line), LineRole); firstItem->setData(QVariant(v8event->filename), FilenameRole);
newRow.at(0)->setData(QVariant(-1),ColumnRole); // v8 events have no column info firstItem->setData(QVariant(v8event->line), LineRole);
newRow.at(0)->setData(QVariant(v8event->eventId), EventIdRole); firstItem->setData(QVariant(-1),ColumnRole); // v8 events have no column info
firstItem->setData(QVariant(v8event->eventId), EventIdRole);
// append // append
m_model->invisibleRootItem()->appendRow(newRow); m_model->invisibleRootItem()->appendRow(newRow);