From 997ece43615d98b213b9f9306a4b0c51726db01e Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Fri, 16 Feb 2018 12:45:43 +0100 Subject: [PATCH] Project: Remove unused Project::requiresTargetPanel(...) Change-Id: I7a5298edefd7e26841c4070be23534dd33d093cb Reviewed-by: hjk --- src/plugins/cmakeprojectmanager/cmakeproject.cpp | 5 ----- src/plugins/cmakeprojectmanager/cmakeproject.h | 1 - src/plugins/projectexplorer/project.cpp | 5 ----- src/plugins/projectexplorer/project.h | 1 - src/plugins/qbsprojectmanager/qbsproject.h | 1 - src/plugins/qmakeprojectmanager/qmakeproject.cpp | 5 ----- src/plugins/qmakeprojectmanager/qmakeproject.h | 2 -- 7 files changed, 20 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakeproject.cpp b/src/plugins/cmakeprojectmanager/cmakeproject.cpp index cd29127f6a7..5604e448da2 100644 --- a/src/plugins/cmakeprojectmanager/cmakeproject.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeproject.cpp @@ -366,11 +366,6 @@ bool CMakeProject::needsConfiguration() const return targets().isEmpty(); } -bool CMakeProject::requiresTargetPanel() const -{ - return !targets().isEmpty(); -} - bool CMakeProject::knowsAllBuildExecutables() const { return false; diff --git a/src/plugins/cmakeprojectmanager/cmakeproject.h b/src/plugins/cmakeprojectmanager/cmakeproject.h index c8e80df7b14..60f605dd7e8 100644 --- a/src/plugins/cmakeprojectmanager/cmakeproject.h +++ b/src/plugins/cmakeprojectmanager/cmakeproject.h @@ -69,7 +69,6 @@ public: CMakeBuildTarget buildTargetForTitle(const QString &title); bool needsConfiguration() const final; - bool requiresTargetPanel() const final; bool knowsAllBuildExecutables() const final; bool supportsKit(const ProjectExplorer::Kit *k, QString *errorMessage = nullptr) const final; diff --git a/src/plugins/projectexplorer/project.cpp b/src/plugins/projectexplorer/project.cpp index abcd9e9a018..6dd2c7bf8bf 100644 --- a/src/plugins/projectexplorer/project.cpp +++ b/src/plugins/projectexplorer/project.cpp @@ -826,11 +826,6 @@ void Project::configureAsExampleProject(const QSet &platforms) Q_UNUSED(platforms); } -bool Project::requiresTargetPanel() const -{ - return true; -} - bool Project::needsSpecialDeployment() const { return false; diff --git a/src/plugins/projectexplorer/project.h b/src/plugins/projectexplorer/project.h index 4e8864222a7..8451103cc33 100644 --- a/src/plugins/projectexplorer/project.h +++ b/src/plugins/projectexplorer/project.h @@ -155,7 +155,6 @@ public: virtual bool needsConfiguration() const; virtual void configureAsExampleProject(const QSet &platforms); - virtual bool requiresTargetPanel() const; virtual ProjectImporter *projectImporter() const; Kit::Predicate requiredKitPredicate() const; diff --git a/src/plugins/qbsprojectmanager/qbsproject.h b/src/plugins/qbsprojectmanager/qbsproject.h index afa2473f337..999fc20ed03 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.h +++ b/src/plugins/qbsprojectmanager/qbsproject.h @@ -135,7 +135,6 @@ private: void projectLoaded() override; ProjectExplorer::ProjectImporter *projectImporter() const override; bool needsConfiguration() const override { return targets().isEmpty(); } - bool requiresTargetPanel() const override { return !targets().isEmpty(); } static bool ensureWriteableQbsFile(const QString &file); diff --git a/src/plugins/qmakeprojectmanager/qmakeproject.cpp b/src/plugins/qmakeprojectmanager/qmakeproject.cpp index eece4ecc84c..0c1e7982c56 100644 --- a/src/plugins/qmakeprojectmanager/qmakeproject.cpp +++ b/src/plugins/qmakeprojectmanager/qmakeproject.cpp @@ -1051,11 +1051,6 @@ void QmakeProject::configureAsExampleProject(const QSet &platforms) qDeleteAll(infoList); } -bool QmakeProject::requiresTargetPanel() const -{ - return !targets().isEmpty(); -} - // All the Qmake run configurations should share code. // This is a rather suboptimal way to do that for disabledReason() // but more pratical then duplicated the code everywhere diff --git a/src/plugins/qmakeprojectmanager/qmakeproject.h b/src/plugins/qmakeprojectmanager/qmakeproject.h index 743be56ce7c..c5a9fb32dca 100644 --- a/src/plugins/qmakeprojectmanager/qmakeproject.h +++ b/src/plugins/qmakeprojectmanager/qmakeproject.h @@ -109,8 +109,6 @@ public: void configureAsExampleProject(const QSet &platforms) final; - bool requiresTargetPanel() const final; - /// \internal QString disabledReasonForRunConfiguration(const Utils::FileName &proFilePath);