From 99c9c3c3c0013b1e58f505e5d5ab8cf31ce7531d Mon Sep 17 00:00:00 2001
From: Tobias Hunger <tobias.hunger@nokia.com>
Date: Mon, 30 Nov 2009 13:26:27 +0100
Subject: [PATCH] Fix reordering of build steps in the clean list

 * Fix reordering of build steps in the clean list of steps.
 * Make the code more robust and avoid removing and inserting
   the item.
 * Update code for the build steps list too for reasons of symetry.

Reviewed-by: dt
---
 src/plugins/projectexplorer/buildconfiguration.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp
index 0789813b620..a9cbeda862e 100644
--- a/src/plugins/projectexplorer/buildconfiguration.cpp
+++ b/src/plugins/projectexplorer/buildconfiguration.cpp
@@ -143,8 +143,10 @@ void BuildConfiguration::removeBuildStep(int position)
 
 void BuildConfiguration::moveBuildStepUp(int position)
 {
-    BuildStep *bs = m_buildSteps.takeAt(position);
-    m_buildSteps.insert(position - 1, bs);
+    if (position <= 0 || m_buildSteps.size() <= 1)
+        return;
+    m_buildSteps.swap(position - 1, position);
+
 }
 
 QList<BuildStep *> BuildConfiguration::cleanSteps() const
@@ -165,8 +167,9 @@ void BuildConfiguration::removeCleanStep(int position)
 
 void BuildConfiguration::moveCleanStepUp(int position)
 {
-    BuildStep *cs = m_cleanSteps.takeAt(position);
-    m_cleanSteps.insert(position, cs);
+    if (position <= 0 || m_cleanSteps.size() <= 1)
+        return;
+    m_cleanSteps.swap(position - 1, position);
 }
 
 ///