feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Pimpl CMakeProjectPlugin and avoid use of global object pool

Browse Source 
Follows the recent pattern.

Change-Id: Ib91fb8e6ab343b5e595b9ed470daa3e55999f37c
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2018-02-09 15:35:02 +01:00
parent 08e73d1a93
commit 9a3dff8934
2 changed files with 46 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/cmakeprojectmanager/cmakeprojectplugin.h
View File

@@ -27,14 +27,7 @@
#include <extensionsystem/iplugin.h>
#include <QObject>
namespace Utils { class ParameterAction; }
namespace CMakeProjectManager {
class CMakeProject;
namespace Internal {
class CMakeProjectPlugin : public ExtensionSystem::IPlugin
@@ -43,9 +36,7 @@ class CMakeProjectPlugin : public ExtensionSystem::IPlugin
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "CMakeProjectManager.json")
public:
bool initialize(const QStringList &arguments, QString *errorMessage) override;
void extensionsInitialized() override;
~CMakeProjectPlugin() override;
#ifdef WITH_TESTS
private slots:
@@ -66,11 +57,13 @@ private slots:
#endif
private:
bool initialize(const QStringList &arguments, QString *errorMessage) override;
void extensionsInitialized() override;
void updateContextActions();
Utils::ParameterAction *m_buildTargetContextAction = nullptr;
QMetaObject::Connection m_actionConnect;
class CMakeProjectPluginPrivate *d = nullptr;
};
} // namespace Internal
} // namespace CMakeProject
} // namespace CMakeProjectManager