Vcs: Convert settings pages to latest style

Last change in that area for this year.

Change-Id: Ibae9f1869cb20faf85c0c1669b84751ad022b8fd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/git/gitsettings.cpp

@@ -5,6 +5,8 @@
 
 #include "gittr.h"
 
+#include <coreplugin/dialogs/ioptionspage.h>
+
 #include <utils/environment.h>
 #include <utils/layoutbuilder.h>
 
@@ -17,20 +19,15 @@ using namespace VcsBase;
 
 namespace Git::Internal {
 
-static GitSettings *theSettings;
-
 GitSettings &settings()
 {
-    return *theSettings;
+    static GitSettings theSettings;
+    return theSettings;
 }
 
 GitSettings::GitSettings()
 {
-    theSettings = this;
-
-    setId(VcsBase::Constants::VCS_ID_GIT);
-    setDisplayName(Tr::tr("Git"));
-    setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY);
+    setAutoApply(false);
     setSettingsGroup("Git");
 
     path.setDisplayStyle(StringAspect::LineEditDisplay);
@@ -175,4 +172,20 @@ FilePath GitSettings::gitExecutable(bool *ok, QString *errorMessage) const
     return resolvedBinPath;
 }
 
+// GitSettingsPage
+
+class GitSettingsPage final : public Core::IOptionsPage
+{
+public:
+    GitSettingsPage()
+    {
+        setId(VcsBase::Constants::VCS_ID_GIT);
+        setDisplayName(Tr::tr("Git"));
+        setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY);
+        setSettingsProvider([] { return &settings(); });
+    }
+};
+
+const GitSettingsPage settingsPage;
+
 } // Git::Internal