From 9a8531c22f5fa16d052725081363856b15657bf0 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 23 Oct 2023 19:56:59 +0200 Subject: [PATCH] DockFocusController: Avoid using sender() in onFocusedDockAreaViewToggled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since m_focusedArea is always a sender of the signal connected to the onFocusedDockAreaViewToggled() slot, reuse it in place of sender(). Change-Id: I17b817132c8b74e825f0accb9c1d467bfdf24ac3 Reviewed-by: Henning Gründl Reviewed-by: Qt CI Bot --- .../advanceddockingsystem/dockfocuscontroller.cpp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp index a9fd274004c..549e13c5a94 100644 --- a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp +++ b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp @@ -267,16 +267,9 @@ void DockFocusController::onFocusedDockAreaViewToggled(bool open) if (d->m_dockManager->isRestoringState() || !d->m_focusedArea || open) return; - DockAreaWidget *dockArea = qobject_cast(sender()); - if (!dockArea || open) - return; - - auto container = dockArea->dockContainer(); - auto openedDockAreas = container->openedDockAreas(); - if (openedDockAreas.isEmpty()) - return; - - d->updateDockWidgetFocus(openedDockAreas[0]->currentDockWidget()); + const auto openedDockAreas = d->m_focusedArea->dockContainer()->openedDockAreas(); + if (!openedDockAreas.isEmpty()) + d->updateDockWidgetFocus(openedDockAreas.first()->currentDockWidget()); } void DockFocusController::notifyWidgetOrAreaRelocation(QWidget *droppedWidget)