From 9ab0510eaf020d43b9021ef17882884b61ad4282 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@qt.io>
Date: Tue, 7 Jun 2022 10:06:39 +0200
Subject: [PATCH] Aspects: Update of combo box when changing TriState value

Call SelectionAspect::setValue instead of skipping it and calling
BaseAspect::setValue directly. That takes care of updating the combo box
state.

Amends c8829ff5b38bf46b8c31590228a93e1aba4a829a

Change-Id: I55e90459c2b54da09883f746b61b19d46acfdf92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
---
 src/libs/utils/aspects.cpp | 2 +-
 src/libs/utils/aspects.h   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libs/utils/aspects.cpp b/src/libs/utils/aspects.cpp
index cac5f7148c0..998d9fa5cc1 100644
--- a/src/libs/utils/aspects.cpp
+++ b/src/libs/utils/aspects.cpp
@@ -1994,7 +1994,7 @@ TriState TriStateAspect::value() const
 
 void TriStateAspect::setValue(TriState value)
 {
-    BaseAspect::setValue(value.toVariant());
+    SelectionAspect::setValue(value.toInt());
 }
 
 void TriStateAspect::setDefaultValue(TriState value)
diff --git a/src/libs/utils/aspects.h b/src/libs/utils/aspects.h
index 643f977fc83..bade3c9495f 100644
--- a/src/libs/utils/aspects.h
+++ b/src/libs/utils/aspects.h
@@ -487,6 +487,7 @@ class QTCREATOR_UTILS_EXPORT TriState
 public:
     TriState() = default;
 
+    int toInt() const { return int(m_value); }
     QVariant toVariant() const { return int(m_value); }
     static TriState fromVariant(const QVariant &variant);