feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Use QtcProcess instead of QProcess for LLDB

Browse Source 
More similar to what GDB does.

Change-Id: I2c5e952261119f04a515f8b8e79a66c397bff6df
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-06-05 12:31:39 +02:00
parent 9890ddfc9a
commit 9af735e2ae
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/debugger/lldb/lldbengine.cpp
View File

@@ -253,11 +253,12 @@ void LldbEngine::startLldb()
this, &LldbEngine::handleResponse, Qt::QueuedConnection); this, &LldbEngine::handleResponse, Qt::QueuedConnection);
showMessage(_("STARTING LLDB: ") + m_lldbCmd); showMessage(_("STARTING LLDB: ") + m_lldbCmd);
m_lldbProc.setEnvironment(runParameters().environment.toStringList()); m_lldbProc.setEnvironment(runParameters().environment);
if (!runParameters().workingDirectory.isEmpty()) if (!runParameters().workingDirectory.isEmpty())
m_lldbProc.setWorkingDirectory(runParameters().workingDirectory); m_lldbProc.setWorkingDirectory(runParameters().workingDirectory);
m_lldbProc.start(m_lldbCmd); m_lldbProc.setCommand(m_lldbCmd, QString());
m_lldbProc.start();
if (!m_lldbProc.waitForStarted()) { if (!m_lldbProc.waitForStarted()) {
const QString msg = tr("Unable to start LLDB \"%1\": %2") const QString msg = tr("Unable to start LLDB \"%1\": %2")

3
src/plugins/debugger/lldb/lldbengine.h
View File

@@ -39,6 +39,7 @@
#include <debugger/debuggerprotocol.h> #include <debugger/debuggerprotocol.h>
#include <utils/consoleprocess.h> #include <utils/consoleprocess.h>
#include <utils/qtcprocess.h>
#include <QPointer> #include <QPointer>
#include <QProcess> #include <QProcess>
@@ -183,7 +184,7 @@ private:
QByteArray m_inbuffer; QByteArray m_inbuffer;
QString m_scriptFileName; QString m_scriptFileName;
QProcess m_lldbProc; Utils::QtcProcess m_lldbProc;
QString m_lldbCmd; QString m_lldbCmd;
// FIXME: Make generic. // FIXME: Make generic.