From 9b1a85d61bd9f3eb6ac447c69c3ede56dfbd198c Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 10 Jan 2025 13:21:08 +0100 Subject: [PATCH] Debugger: Get rid of DebuggerRunParameters::skipExecutableValidation It was only set, but never read. Task-number: QTCREATORBUG-29168 Change-Id: I441a0c4d2a13a09a938a072b286e1a940ed72ed8 Reviewed-by: hjk --- src/plugins/android/androiddebugsupport.cpp | 1 - src/plugins/debugger/debuggerengine.h | 2 -- src/plugins/debugger/debuggerruncontrol.cpp | 5 ----- src/plugins/debugger/debuggerruncontrol.h | 1 - 4 files changed, 9 deletions(-) diff --git a/src/plugins/android/androiddebugsupport.cpp b/src/plugins/android/androiddebugsupport.cpp index 879cc7b8826..8cb93a0cd16 100644 --- a/src/plugins/android/androiddebugsupport.cpp +++ b/src/plugins/android/androiddebugsupport.cpp @@ -127,7 +127,6 @@ public: rp.setSolibSearchPath(solibSearchPath); qCDebug(androidDebugSupportLog).noquote() << "SoLibSearchPath: " << solibSearchPath; rp.setSymbolFile(androidAppProcessDir(target).pathAppended("app_process")); - setSkipExecutableValidation(true); rp.setUseExtendedRemote(true); QString devicePreferredAbi = apkDevicePreferredAbi(target); setAbi(androidAbi2Abi(devicePreferredAbi)); diff --git a/src/plugins/debugger/debuggerengine.h b/src/plugins/debugger/debuggerengine.h index c0261ae06ab..adcfaa0bc2b 100644 --- a/src/plugins/debugger/debuggerengine.h +++ b/src/plugins/debugger/debuggerengine.h @@ -144,8 +144,6 @@ public: void setUseCtrlCStub(bool on) { m_useCtrlCStub = on; } bool useCtrlCStub() const { return m_useCtrlCStub; } - // Used by Android to avoid false positives on warnOnRelease - bool skipExecutableValidation = false; bool useTargetAsync = false; Utils::FilePaths additionalSearchDirectories; diff --git a/src/plugins/debugger/debuggerruncontrol.cpp b/src/plugins/debugger/debuggerruncontrol.cpp index 199fc41161d..971482c60a6 100644 --- a/src/plugins/debugger/debuggerruncontrol.cpp +++ b/src/plugins/debugger/debuggerruncontrol.cpp @@ -123,11 +123,6 @@ void DebuggerRunTool::setContinueAfterAttach(bool on) m_runParameters.continueAfterAttach = on; } -void DebuggerRunTool::setSkipExecutableValidation(bool on) -{ - m_runParameters.skipExecutableValidation = on; -} - void DebuggerRunTool::setBreakOnMain(bool on) { m_runParameters.breakOnMain = on; diff --git a/src/plugins/debugger/debuggerruncontrol.h b/src/plugins/debugger/debuggerruncontrol.h index a133c14ee3a..9a959c1dfa7 100644 --- a/src/plugins/debugger/debuggerruncontrol.h +++ b/src/plugins/debugger/debuggerruncontrol.h @@ -65,7 +65,6 @@ public: void addSearchDirectory(const Utils::FilePath &dir); void setUseTargetAsync(bool on); - void setSkipExecutableValidation(bool on); void setIosPlatform(const QString &platform); void setDeviceSymbolsRoot(const QString &deviceSymbolsRoot);