From 9b21b643ca093783ac3d86e6bdcbd45a602ab1ab Mon Sep 17 00:00:00 2001
From: Mahmoud Badri <mahmoud.badri@qt.io>
Date: Mon, 10 Jun 2024 18:01:14 +0300
Subject: [PATCH] QmlDesigner: Remove AbstractView::emitCustomNotification()
 overloads

Use default params instead

Change-Id: I5e8f7bc2bf29e266768fdabb6d000d058499733e
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
---
 .../qmldesigner/designercore/include/abstractview.h |  5 ++---
 .../qmldesigner/designercore/model/abstractview.cpp | 13 ++-----------
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/src/plugins/qmldesigner/designercore/include/abstractview.h b/src/plugins/qmldesigner/designercore/include/abstractview.h
index 2fbc0ae344d..694bdc6448b 100644
--- a/src/plugins/qmldesigner/designercore/include/abstractview.h
+++ b/src/plugins/qmldesigner/designercore/include/abstractview.h
@@ -132,9 +132,8 @@ public:
 
     void emitDocumentMessage(const QList<DocumentMessage> &errors, const QList<DocumentMessage> &warnings = {});
     void emitDocumentMessage(const QString &error);
-    void emitCustomNotification(const QString &identifier);
-    void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList);
-    void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data);
+    void emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList = {},
+                                const QList<QVariant> &data = {});
 
     void emitInstancePropertyChange(const QList<QPair<ModelNode, PropertyName> > &propertyList);
     void emitInstanceErrorChange(const QVector<qint32> &instanceIds);
diff --git a/src/plugins/qmldesigner/designercore/model/abstractview.cpp b/src/plugins/qmldesigner/designercore/model/abstractview.cpp
index 35ccf36efd8..254f9536f9c 100644
--- a/src/plugins/qmldesigner/designercore/model/abstractview.cpp
+++ b/src/plugins/qmldesigner/designercore/model/abstractview.cpp
@@ -669,17 +669,8 @@ void AbstractView::emitDocumentMessage(const QList<DocumentMessage> &errors, con
         model()->d->setDocumentMessages(errors, warnings);
 }
 
-void AbstractView::emitCustomNotification(const QString &identifier)
-{
-    emitCustomNotification(identifier, QList<ModelNode>());
-}
-
-void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList)
-{
-    emitCustomNotification(identifier, nodeList, QList<QVariant>());
-}
-
-void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList, const QList<QVariant> &data)
+void AbstractView::emitCustomNotification(const QString &identifier, const QList<ModelNode> &nodeList,
+                                          const QList<QVariant> &data)
 {
     if (model())
         model()->d->notifyCustomNotification(this, identifier, nodeList, data);