feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Collapse BuildInfo hierarchy

Browse Source 
... to pass it around as real values, avoiding, among others,
the need of occasional explicit deletion.

The formerly extra members of the derived stuff are handled via
an extra variant (for data) and via a functor in the build
configuration factory.

The change is mechanical.

Change-Id: I19ca4e0c5f0a5b196fc16dfb98bb005dc679f855
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-29 16:51:17 +01:00
parent 5cf2889856
commit 9bb936499d
45 changed files with 418 additions and 595 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -57,7 +57,6 @@ using namespace ProjectExplorer::Internal;
BuildSettingsWidget::~BuildSettingsWidget()
{
clearWidgets();
qDeleteAll(m_buildInfoList);
}
BuildSettingsWidget::BuildSettingsWidget(Target *target) :
@@ -176,16 +175,13 @@ QList<NamedWidget *> BuildSettingsWidget::subWidgets() const
void BuildSettingsWidget::updateAddButtonMenu()
{
m_addButtonMenu->clear();
qDeleteAll(m_buildInfoList);
m_buildInfoList.clear();
if (m_target) {
BuildConfigurationFactory *factory = BuildConfigurationFactory::find(m_target);
if (!factory)
return;
m_buildInfoList = factory->availableBuilds(m_target);
foreach (BuildInfo *info, m_buildInfoList) {
QAction *action = m_addButtonMenu->addAction(info->typeName);
for (const BuildInfo &info : factory->allAvailableBuilds(m_target)) {
QAction *action = m_addButtonMenu->addAction(info.typeName);
connect(action, &QAction::triggered, this, [this, info] {
createConfiguration(info);
});
@@ -239,28 +235,26 @@ void BuildSettingsWidget::updateActiveConfiguration()
updateBuildSettings();
}
void BuildSettingsWidget::createConfiguration(BuildInfo *info)
void BuildSettingsWidget::createConfiguration(const BuildInfo &info_)
{
QString originalDisplayName = info->displayName;
if (info->displayName.isEmpty()) {
BuildInfo info = info_;
if (info.displayName.isEmpty()) {
bool ok = false;
info->displayName = QInputDialog::getText(Core::ICore::mainWindow(),
info.displayName = QInputDialog::getText(Core::ICore::mainWindow(),
tr("New Configuration"),
tr("New configuration name:"),
QLineEdit::Normal,
QString(), &ok).trimmed();
if (!ok || info->displayName.isEmpty())
if (!ok || info.displayName.isEmpty())
return;
}
BuildConfiguration *bc = info->factory()->create(m_target, info);
BuildConfiguration *bc = info.factory()->create(m_target, info);
if (!bc)
return;
m_target->addBuildConfiguration(bc);
SessionManager::setActiveBuildConfiguration(m_target, bc, SetActive::Cascade);
info->displayName = originalDisplayName;
}
QString BuildSettingsWidget::uniqueName(const QString & name)