feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Separate plugin and QObject parent roles for VcsSubmitEditorFactory

Browse Source 
These are different when the factories are used as real members,
as already done in Bazaar.

Change-Id: I3c187896dcbacb5156be1543424ccacb9140a493
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-02-06 15:52:30 +01:00
parent e4738904d9
commit 9c02a11039
8 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/perforce/perforceplugin.cpp
View File

@@ -381,7 +381,7 @@ PerforcePluginPrivate::PerforcePluginPrivate()
m_settings.fromSettings(ICore::settings());
// Editor factories
new VcsSubmitEditorFactory(submitParameters, [] { return new PerforceSubmitEditor; }, this);
new VcsSubmitEditorFactory(submitParameters, [] { return new PerforceSubmitEditor; }, this, this);
const auto describeFunc = [this](const QString &source, const QString &n) {
describe(source, n);