Vcs: Separate plugin and QObject parent roles for VcsSubmitEditorFactory

These are different when the factories are used as real members,
as already done in Bazaar.

Change-Id: I3c187896dcbacb5156be1543424ccacb9140a493
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/vcsbase/basevcssubmiteditorfactory.cpp

@@ -43,8 +43,9 @@ const char DIFF_SELECTED[] = "Vcs.DiffSelectedFiles";
 VcsSubmitEditorFactory::VcsSubmitEditorFactory
         (const VcsBaseSubmitEditorParameters &parameters,
          const EditorCreator &editorCreator,
-         VcsBasePluginPrivate *plugin)
-    : IEditorFactory(plugin)
+         VcsBasePluginPrivate *plugin,
+         QObject *parent)
+    : IEditorFactory(parent)
 {
     setId(parameters.id);
     setDisplayName(QLatin1String(parameters.displayName));