feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify DeployConfigFactory::availableBuildTargets

Browse Source 
It only ever returned either an empty list, or a list with a single
empty string. Using a bool return value to distiguish the cases is
less convoluted.

This is a leftover from the time when a DeployConfigurationFactory
could potentially create more than on DeployConfiguration, but this
is not supported anymore, as factories are cheap nowadays.

Change-Id: I4f2a91d3509d2b978949211ee709863d5ff460c7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-15 15:25:45 +01:00
parent 54385ad67b
commit 9c23e37f5d
4 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/android/androiddeployconfiguration.h
View File

@@ -44,7 +44,7 @@ class AndroidDeployConfigurationFactory : public ProjectExplorer::DeployConfigur
public:
AndroidDeployConfigurationFactory();
QList<QString> availableBuildTargets(ProjectExplorer::Target *parent) const override;
bool hasAvailableBuildTargets(ProjectExplorer::Target *parent) const override;
};
} // namespace Internal