feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fixes: - Warning about wrong connect

Browse Source 
Details:  - Bookmarks plugin accidentally thought all editors are text editors.
This commit is contained in:
con
2008-12-10 13:58:02 +01:00
parent 65f07aa2de
commit 9c244bcbde
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/bookmarks/bookmarksplugin.cpp
View File

@@ -201,14 +201,18 @@ void BookmarksPlugin::updateActions(int state)
void BookmarksPlugin::editorOpened(Core::IEditor *editor) void BookmarksPlugin::editorOpened(Core::IEditor *editor)
{ {
connect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)), if (qobject_cast<ITextEditor *>(editor)) {
this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*))); connect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
}
} }
void BookmarksPlugin::editorAboutToClose(Core::IEditor *editor) void BookmarksPlugin::editorAboutToClose(Core::IEditor *editor)
{ {
disconnect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)), if (qobject_cast<ITextEditor *>(editor)) {
this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*))); disconnect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
}
} }
void BookmarksPlugin::requestContextMenu(TextEditor::ITextEditor *editor, void BookmarksPlugin::requestContextMenu(TextEditor::ITextEditor *editor,