From 9c47990a0a19726d12bf543cf23e8337b3401a74 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 28 Sep 2022 15:13:10 +0200 Subject: [PATCH] VcsBase: Simplify QActionPushButton implementation No need for Q_OBJECT. Change-Id: I72510ef2e4a722286d12c93016a92370393ca32c Reviewed-by: Orgad Shaneh --- src/plugins/vcsbase/submiteditorwidget.cpp | 30 +++++++++------------- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/src/plugins/vcsbase/submiteditorwidget.cpp b/src/plugins/vcsbase/submiteditorwidget.cpp index bcb1d742d9f..782d8856aaf 100644 --- a/src/plugins/vcsbase/submiteditorwidget.cpp +++ b/src/plugins/vcsbase/submiteditorwidget.cpp @@ -67,24 +67,20 @@ namespace VcsBase { // (similar to a QToolButton) class QActionPushButton : public QToolButton { - Q_OBJECT public: - explicit QActionPushButton(QAction *a); -}; - -QActionPushButton::QActionPushButton(QAction *a) : - QToolButton() -{ - setIcon(a->icon()); - setText(a->text()); - setToolButtonStyle(Qt::ToolButtonTextBesideIcon); - connect(a, &QAction::changed, this, [this, a] { - setEnabled(a->isEnabled()); + explicit QActionPushButton(QAction *a) + { + setIcon(a->icon()); setText(a->text()); - }); - connect(this, &QAbstractButton::clicked, a, &QAction::trigger); - setEnabled(a->isEnabled()); -} + setToolButtonStyle(Qt::ToolButtonTextBesideIcon); + connect(a, &QAction::changed, this, [this, a] { + setEnabled(a->isEnabled()); + setText(a->text()); + }); + connect(this, &QAbstractButton::clicked, a, &QAction::trigger); + setEnabled(a->isEnabled()); + } +}; // Helpers to retrieve model data // Convenience to extract a list of selected indexes @@ -765,5 +761,3 @@ void SubmitEditorWidget::setEmptyFileListEnabled(bool e) } } // namespace VcsBase - -#include "submiteditorwidget.moc"