feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Improve interfaces

Browse Source 
The interfaces should never used to handle ownership. So it is now using
protected destructors. Copy operations are forbidden too.

https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c35-a-base-class-destructor-should-be-either-public-and-virtual-or-protected-and-nonvirtual

Change-Id: Ib0b60a73a7ec130973b5cb0095cc5b2f10fa0758
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Marco Bubke
2018-03-12 14:08:18 +01:00
parent f1e02c0826
commit 9c4bfbe20a
52 changed files with 186 additions and 316 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/clangrefactoring/searchinterface.h
View File

@@ -36,9 +36,15 @@ namespace ClangRefactoring {
class SearchInterface
{
public:
virtual ~SearchInterface();
SearchInterface() = default;
SearchInterface(const SearchInterface &) = delete;
SearchInterface &operator=(const SearchInterface &) = delete;
virtual std::unique_ptr<SearchHandle> startNewSearch(const QString &searchLabel,
const QString &searchTerm) = 0;
const QString &searchTerm) = 0;
protected:
~SearchInterface() = default;
};
} // namespace ClangRefactoring