From 9c88b03415f927b43152866bb6fa6329c7a6a751 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Mon, 10 Oct 2016 17:10:32 +0200 Subject: [PATCH] ClangStaticAnalyzer: Tests: Clarify meaning of assert 'arguments.first().toBool()' returned FALSE ...is not very expressive. Change-Id: Ia0c8e8fbe2e84ea4f41668a5179a63e2003bab03 Reviewed-by: Christian Kandeler --- .../clangstaticanalyzerpreconfiguredsessiontests.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzerpreconfiguredsessiontests.cpp b/src/plugins/clangstaticanalyzer/clangstaticanalyzerpreconfiguredsessiontests.cpp index 83d9c104432..eacaa7f4acd 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzerpreconfiguredsessiontests.cpp +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzerpreconfiguredsessiontests.cpp @@ -107,7 +107,8 @@ void ClangStaticAnalyzerPreconfiguredSessionTests::testPreconfiguredSession() QSignalSpy waitUntilAnalyzerFinished(&m_analyzerTool, SIGNAL(finished(bool))); QVERIFY(waitUntilAnalyzerFinished.wait(30000)); const QList arguments = waitUntilAnalyzerFinished.takeFirst(); - QVERIFY(arguments.first().toBool()); + const bool analyzerFinishedSuccessfully = arguments.first().toBool(); + QVERIFY(analyzerFinishedSuccessfully); QCOMPARE(m_analyzerTool.diagnostics().count(), 0); }