From 9c930ac744412f1a63f3620b584f8585630f787a Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 6 Aug 2020 09:01:39 +0200 Subject: [PATCH] Meson: Cleanup mesonprojectplugin.* Some unnneded code + final. Change-Id: Ied2a29d20c624b8e5e2eefb56253b0412554ad44 Reviewed-by: Alexis Jeandet Reviewed-by: Christian Stenger --- .../mesonprojectmanager/mesonprojectplugin.cpp | 11 ----------- src/plugins/mesonprojectmanager/mesonprojectplugin.h | 12 +++--------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp b/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp index 04904188312..6e0b58e1f9a 100644 --- a/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp +++ b/src/plugins/mesonprojectmanager/mesonprojectplugin.cpp @@ -38,20 +38,11 @@ #include "settings/tools/toolssettingsaccessor.h" #include "settings/tools/toolssettingspage.h" -#include -#include #include -#include #include #include -#include - -#include - -#include - using namespace Core; using namespace ProjectExplorer; using namespace Utils; @@ -113,8 +104,6 @@ bool MesonProjectPlugin::initialize(const QStringList & /*arguments*/, QString * return true; } -void MesonProjectPlugin::extensionsInitialized() {} - } // namespace Internal } // namespace MesonProjectManager diff --git a/src/plugins/mesonprojectmanager/mesonprojectplugin.h b/src/plugins/mesonprojectmanager/mesonprojectplugin.h index 8cbcfa10bae..15ef78e407b 100644 --- a/src/plugins/mesonprojectmanager/mesonprojectplugin.h +++ b/src/plugins/mesonprojectmanager/mesonprojectplugin.h @@ -30,22 +30,16 @@ namespace MesonProjectManager { namespace Internal { -class MesonProjectPlugin : public ExtensionSystem::IPlugin +class MesonProjectPlugin final : public ExtensionSystem::IPlugin { Q_OBJECT Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "MesonProjectManager.json") public: - ~MesonProjectPlugin() override; - -#ifdef WITH_TESTS -private slots: - -#endif + ~MesonProjectPlugin() final; private: - bool initialize(const QStringList &arguments, QString *errorMessage) override; - void extensionsInitialized() override; + bool initialize(const QStringList &arguments, QString *errorMessage) final; class MesonProjectPluginPrivate *d = nullptr; };