feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Make VcsBaseEditorWidget::test* operate on factories directly

Browse Source 
Saves re-discovery by id.

Change-Id: I026c1388d02f125147a9b4f5367d7a1a266bff3c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-02-12 11:51:45 +01:00
parent bbf3682c2c
commit 9c96a1c4de
11 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/mercurial/mercurialplugin.cpp
View File

@@ -222,6 +222,7 @@ private:
bool m_submitActionTriggered = false;
public:
VcsSubmitEditorFactory submitEditorFactory {
submitEditorParameters,
[] { return new CommitEditor; },
@@ -901,7 +902,7 @@ void MercurialPlugin::testDiffFileResolving_data()
void MercurialPlugin::testDiffFileResolving()
{
VcsBaseEditorWidget::testDiffFileResolving(diffEditorParameters.id);
VcsBaseEditorWidget::testDiffFileResolving(dd->diffEditorFactory);
}
void MercurialPlugin::testLogResolving()
@@ -921,7 +922,7 @@ void MercurialPlugin::testLogResolving()
"date: Sat Jan 19 04:08:16 2013 +0100\n"
"summary: test-rebase: add another test for rebase with multiple roots\n"
);
VcsBaseEditorWidget::testLogResolving(logEditorParameters.id, data, "18473:692cbda1eb50", "18472:37100f30590f");
VcsBaseEditorWidget::testLogResolving(dd->logEditorFactory, data, "18473:692cbda1eb50", "18472:37100f30590f");
}
#endif