From 9cc50a96e4c9ea1ed562e9140863933a9c5da872 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Fri, 15 Apr 2016 12:02:10 +0200 Subject: [PATCH] Clang: Fix updating warning config widgets on remove Problematic use case was: 1. Go to projects mode, select "Clang Code Model" 2. Click "Copy...", click "OK" and add e.g. " -Wbla" 3. Click "Remove" ==> The configuration is reset (combobox), but the warning options are not (" -Wbla" is still there). Change-Id: Ifc445a3fa0e3b3191915cf7bca220f4bef848069 Reviewed-by: Christian Stenger --- src/plugins/cpptools/clangdiagnosticconfigswidget.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/cpptools/clangdiagnosticconfigswidget.cpp b/src/plugins/cpptools/clangdiagnosticconfigswidget.cpp index 55213d4f246..bb3d55c3cc3 100644 --- a/src/plugins/cpptools/clangdiagnosticconfigswidget.cpp +++ b/src/plugins/cpptools/clangdiagnosticconfigswidget.cpp @@ -157,10 +157,12 @@ void ClangDiagnosticConfigsWidget::syncConfigChooserToModel(const Core::Id &conf connectConfigChooserCurrentIndex(); - if (configToSelectIndex != -1) + if (configToSelectIndex != -1) { m_ui->configChooserComboBox->setCurrentIndex(configToSelectIndex); - else if (previousCurrentIndex != m_ui->configChooserComboBox->currentIndex()) + } else if (previousCurrentIndex != m_ui->configChooserComboBox->currentIndex()) { + syncOtherWidgetsToComboBox(); emit currentConfigChanged(currentConfigId()); + } } void ClangDiagnosticConfigsWidget::syncOtherWidgetsToComboBox()