From 9d0099245aeeba7438209593bc43f3010b89c576 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Tue, 21 Feb 2023 13:34:04 +0200 Subject: [PATCH] QmlDesigner: Fix crash at shutdown It is specifically PureActionInterface pointer that is getting deleted, and it is subclassed, so its destructor needs to virtual for delete to work properly. Fixes: QDS-9221 Change-Id: Iba3b9d944de521d7e115b0d85f5a0f107b703fc1 Reviewed-by: Mahmoud Badri --- .../qmldesigner/components/componentcore/abstractaction.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/qmldesigner/components/componentcore/abstractaction.h b/src/plugins/qmldesigner/components/componentcore/abstractaction.h index 06b7795574c..920063ea2d0 100644 --- a/src/plugins/qmldesigner/components/componentcore/abstractaction.h +++ b/src/plugins/qmldesigner/components/componentcore/abstractaction.h @@ -14,6 +14,7 @@ class QMLDESIGNERCOMPONENTS_EXPORT PureActionInterface { public: explicit PureActionInterface(QAction *action); + virtual ~PureActionInterface() = default; virtual void setSelectionContext(const SelectionContext &selectionContext) = 0; QAction *action();