From 9d0b661551793c82bc1998fa9af1439fb34f305e Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 9 Feb 2021 11:54:22 +0100 Subject: [PATCH] ClassView: Remove redundant call to clearCache() before resetParser() clearCache() is already called from inside Manager::resetParser() -> Parser::resetDataToCurrentState() -> Parser::resetData() -> Parser::clearCache(). Change-Id: I270be85b291f99552959e50ee54bd6e1f293c63a Reviewed-by: Christian Kandeler --- src/plugins/classview/classviewmanager.cpp | 3 --- src/plugins/classview/classviewparser.cpp | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/plugins/classview/classviewmanager.cpp b/src/plugins/classview/classviewmanager.cpp index a1cf4053751..ce5bfcec204 100644 --- a/src/plugins/classview/classviewmanager.cpp +++ b/src/plugins/classview/classviewmanager.cpp @@ -190,9 +190,6 @@ void Manager::initialize() if (!state()) return; - // any document might be changed, clear parser's cache - QMetaObject::invokeMethod(&d->parser, &Parser::clearCache, Qt::QueuedConnection); - // request to update a tree to the current state resetParser(); }); diff --git a/src/plugins/classview/classviewparser.cpp b/src/plugins/classview/classviewparser.cpp index 414118df9ab..987f2b667df 100644 --- a/src/plugins/classview/classviewparser.cpp +++ b/src/plugins/classview/classviewparser.cpp @@ -600,7 +600,7 @@ void Parser::resetData(const CPlusPlus::Snapshot &snapshot) CPlusPlus::Snapshot::const_iterator cur = snapshot.begin(); CPlusPlus::Snapshot::const_iterator end = snapshot.end(); for (; cur != end; ++cur) - d->documentList[cur.key().toString()] = cur.value(); + d->documentList[cur.key().toString()] = cur.value(); // why we don't clear documentList? d->docLocker.unlock();