diff --git a/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.cpp b/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.cpp index 039d421b201..197dad93cca 100644 --- a/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.cpp +++ b/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.cpp @@ -41,9 +41,9 @@ AbstractActionGroup::AbstractActionGroup(const QString &displayName) : m_action = m_menu->menuAction(); } -AbstractDesignerAction::Type AbstractActionGroup::type() const +ActionInterface::Type AbstractActionGroup::type() const { - return AbstractDesignerAction::Menu; + return ActionInterface::Menu; } QAction *AbstractActionGroup::action() const diff --git a/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.h b/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.h index ea30a428f38..1061cd47623 100644 --- a/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.h +++ b/src/plugins/qmldesigner/components/componentcore/abstractactiongroup.h @@ -30,7 +30,7 @@ #ifndef MENUDESIGNERACTION_H #define MENUDESIGNERACTION_H -#include "abstractdesigneraction.h" +#include "actioninterface.h" #include #include @@ -38,14 +38,14 @@ namespace QmlDesigner { -class QMLDESIGNERCORE_EXPORT AbstractActionGroup : public AbstractDesignerAction +class QMLDESIGNERCORE_EXPORT AbstractActionGroup : public ActionInterface { public: AbstractActionGroup(const QString &displayName); virtual bool isVisible(const SelectionContext &m_selectionState) const = 0; virtual bool isEnabled(const SelectionContext &m_selectionState) const = 0; - AbstractDesignerAction::Type type() const QTC_OVERRIDE; + ActionInterface::Type type() const QTC_OVERRIDE; QAction *action() const QTC_OVERRIDE; QMenu *menu() const; SelectionContext selectionContext() const; diff --git a/src/plugins/qmldesigner/components/componentcore/abstractdesigneraction.h b/src/plugins/qmldesigner/components/componentcore/actioninterface.h similarity index 96% rename from src/plugins/qmldesigner/components/componentcore/abstractdesigneraction.h rename to src/plugins/qmldesigner/components/componentcore/actioninterface.h index aaee498e96d..d1ad33674a6 100644 --- a/src/plugins/qmldesigner/components/componentcore/abstractdesigneraction.h +++ b/src/plugins/qmldesigner/components/componentcore/actioninterface.h @@ -39,7 +39,7 @@ QT_END_NAMESPACE namespace QmlDesigner { -class QMLDESIGNERCORE_EXPORT AbstractDesignerAction +class QMLDESIGNERCORE_EXPORT ActionInterface { public: enum Type { @@ -54,7 +54,7 @@ public: LowestPriority = ComponentCoreConstants::priorityLast }; - virtual ~AbstractDesignerAction() {} + virtual ~ActionInterface() {} virtual QAction *action() const = 0; virtual QByteArray category() const = 0; diff --git a/src/plugins/qmldesigner/components/componentcore/componentcore.pri b/src/plugins/qmldesigner/components/componentcore/componentcore.pri index 9e826feec68..959a6ef8c9d 100644 --- a/src/plugins/qmldesigner/components/componentcore/componentcore.pri +++ b/src/plugins/qmldesigner/components/componentcore/componentcore.pri @@ -19,6 +19,6 @@ HEADERS += selectioncontext.h HEADERS += componentcore_constants.h HEADERS += designeractionmanager.h HEADERS += modelnodeoperations.h -HEADERS += abstractdesigneraction.h +HEADERS += actioninterface.h HEADERS += crumblebar.h diff --git a/src/plugins/qmldesigner/components/componentcore/defaultdesigneraction.h b/src/plugins/qmldesigner/components/componentcore/defaultdesigneraction.h index c6291fa3a1d..a199c9c8888 100644 --- a/src/plugins/qmldesigner/components/componentcore/defaultdesigneraction.h +++ b/src/plugins/qmldesigner/components/componentcore/defaultdesigneraction.h @@ -31,7 +31,7 @@ #ifndef QMLDESIGNER_DEFAULTDESIGNERACTION_H #define QMLDESIGNER_DEFAULTDESIGNERACTION_H -#include "abstractdesigneraction.h" +#include "actioninterface.h" #include #include @@ -56,7 +56,7 @@ protected: SelectionContext m_selectionContext; }; -class QMLDESIGNERCORE_EXPORT DefaultDesignerAction : public AbstractDesignerAction +class QMLDESIGNERCORE_EXPORT DefaultDesignerAction : public ActionInterface { public: DefaultDesignerAction(const QString &description = QString()); diff --git a/src/plugins/qmldesigner/components/componentcore/designeractionmanager.cpp b/src/plugins/qmldesigner/components/componentcore/designeractionmanager.cpp index 90ca15b57db..3197ae6da87 100644 --- a/src/plugins/qmldesigner/components/componentcore/designeractionmanager.cpp +++ b/src/plugins/qmldesigner/components/componentcore/designeractionmanager.cpp @@ -431,16 +431,16 @@ void DesignerActionManager::createDefaultDesignerActions() } -void DesignerActionManager::addDesignerAction(AbstractDesignerAction *newAction) +void DesignerActionManager::addDesignerAction(ActionInterface *newAction) { - m_designerActions.append(QSharedPointer(newAction)); + m_designerActions.append(QSharedPointer(newAction)); m_designerActionManagerView->setDesignerActionList(designerActions()); } -QList DesignerActionManager::designerActions() const +QList DesignerActionManager::designerActions() const { - QList list; - foreach (const QSharedPointer &pointer, m_designerActions) { + QList list; + foreach (const QSharedPointer &pointer, m_designerActions) { list.append(pointer.data()); } diff --git a/src/plugins/qmldesigner/components/componentcore/designeractionmanager.h b/src/plugins/qmldesigner/components/componentcore/designeractionmanager.h index b7c4ce6a9db..2b4c125a083 100644 --- a/src/plugins/qmldesigner/components/componentcore/designeractionmanager.h +++ b/src/plugins/qmldesigner/components/componentcore/designeractionmanager.h @@ -31,7 +31,7 @@ #define DESIGNERACTIONMANAGER_H #include -#include "abstractdesigneraction.h" +#include "actioninterface.h" #include "abstractview.h" namespace QmlDesigner { @@ -43,14 +43,14 @@ public: DesignerActionManager(DesignerActionManagerView *designerActionManagerView); ~DesignerActionManager(); - void addDesignerAction(AbstractDesignerAction *newAction); - QList designerActions() const; + void addDesignerAction(ActionInterface *newAction); + QList designerActions() const; void createDefaultDesignerActions(); AbstractView *view(); private: - QList > m_designerActions; + QList > m_designerActions; DesignerActionManagerView *m_designerActionManagerView; }; diff --git a/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.cpp b/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.cpp index b36d1c1e47d..90fa7657d42 100644 --- a/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.cpp +++ b/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.cpp @@ -30,7 +30,7 @@ #include "designeractionmanagerview.h" #include -#include +#include namespace QmlDesigner { @@ -160,7 +160,7 @@ void DesignerActionManagerView::importsChanged(const QList &, const QLis void DesignerActionManagerView::scriptFunctionsChanged(const ModelNode &, const QStringList &) {} -void DesignerActionManagerView::setDesignerActionList(const QList &designerActionList) +void DesignerActionManagerView::setDesignerActionList(const QList &designerActionList) { m_designerActionList = designerActionList; } @@ -187,7 +187,7 @@ void DesignerActionManagerView::setupContext() return; } SelectionContext selectionContext(this); - foreach (AbstractDesignerAction* action, m_designerActionList) { + foreach (ActionInterface* action, m_designerActionList) { action->currentContextChanged(selectionContext); } m_setupContextDirty = false; diff --git a/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.h b/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.h index 0db90389f52..34f16fe5071 100644 --- a/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.h +++ b/src/plugins/qmldesigner/components/componentcore/designeractionmanagerview.h @@ -36,7 +36,7 @@ namespace QmlDesigner { -class AbstractDesignerAction; +class ActionInterface; class DesignerActionManagerView : public AbstractView { @@ -78,7 +78,7 @@ public: void nodeOrderChanged(const NodeListProperty &, const ModelNode &, int ); void importsChanged(const QList &, const QList &); void scriptFunctionsChanged(const ModelNode &, const QStringList &); - void setDesignerActionList(const QList &designerActionList); + void setDesignerActionList(const QList &designerActionList); void signalHandlerPropertiesChanged(const QVector &/*propertyList*/, PropertyChangeFlags /*propertyChange*/); DesignerActionManager &designerActionManager(); @@ -89,7 +89,7 @@ protected: private: DesignerActionManager m_designerActionManager; - QList m_designerActionList; + QList m_designerActionList; bool m_isInRewriterTransaction; bool m_setupContextDirty; }; diff --git a/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu.cpp b/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu.cpp index 88d9a202570..c2afb1c3519 100644 --- a/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu.cpp +++ b/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu.cpp @@ -45,12 +45,12 @@ ModelNodeContextMenu::ModelNodeContextMenu(AbstractView *view) : { } -static QSet findMembers(QSet designerActionSet, +static QSet findMembers(QSet actionInterface, const QString &category) { - QSet ret; + QSet ret; - foreach (AbstractDesignerAction* factory, designerActionSet) { + foreach (ActionInterface* factory, actionInterface) { if (factory->category() == category) ret.insert(factory); } @@ -58,32 +58,32 @@ static QSet findMembers(QSet } -void populateMenu(QSet &abstractDesignerActions, +void populateMenu(QSet &actionInterfaces, const QString &category, QMenu* menu, const SelectionContext &selectionContext) { - QSet matchingFactories = findMembers(abstractDesignerActions, category); + QSet matchingFactories = findMembers(actionInterfaces, category); - abstractDesignerActions.subtract(matchingFactories); + actionInterfaces.subtract(matchingFactories); - QList matchingFactoriesList = matchingFactories.toList(); - Utils::sort(matchingFactoriesList, [](AbstractDesignerAction *l, AbstractDesignerAction *r) { + QList matchingFactoriesList = matchingFactories.toList(); + Utils::sort(matchingFactoriesList, [](ActionInterface *l, ActionInterface *r) { return l->priority() > r->priority(); }); - foreach (AbstractDesignerAction* designerAction, matchingFactoriesList) { - if (designerAction->type() == AbstractDesignerAction::Menu) { - designerAction->currentContextChanged(selectionContext); - QMenu *newMenu = designerAction->action()->menu(); + foreach (ActionInterface* actionInterface, matchingFactoriesList) { + if (actionInterface->type() == ActionInterface::Menu) { + actionInterface->currentContextChanged(selectionContext); + QMenu *newMenu = actionInterface->action()->menu(); menu->addMenu(newMenu); //recurse - populateMenu(abstractDesignerActions, designerAction->menuId(), newMenu, selectionContext); - } else if (designerAction->type() == AbstractDesignerAction::Action) { - QAction* action = designerAction->action(); - designerAction->currentContextChanged(selectionContext); + populateMenu(actionInterfaces, actionInterface->menuId(), newMenu, selectionContext); + } else if (actionInterface->type() == ActionInterface::Action) { + QAction* action = actionInterface->action(); + actionInterface->currentContextChanged(selectionContext); menu->addAction(action); } } @@ -97,8 +97,8 @@ void ModelNodeContextMenu::execute(const QPoint &position, bool selectionMenuBoo m_selectionContext.setScenePosition(m_scenePos); - QSet factories = - QSet::fromList(QmlDesignerPlugin::instance()->designerActionManager().designerActions()); + QSet factories = + QSet::fromList(QmlDesignerPlugin::instance()->designerActionManager().designerActions()); populateMenu(factories, QString(""), mainMenu, m_selectionContext); diff --git a/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu_helper.h b/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu_helper.h index 58f8cdd3898..1c1ee414110 100644 --- a/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu_helper.h +++ b/src/plugins/qmldesigner/components/componentcore/modelnodecontextmenu_helper.h @@ -133,7 +133,7 @@ public: QByteArray category() const { return QByteArray(); } QByteArray menuId() const { return m_menuId; } int priority() const { return m_priority; } - AbstractDesignerAction::Type type() const { return AbstractDesignerAction::Menu; } + Type type() const { return Menu; } private: const QByteArray m_menuId; diff --git a/src/plugins/qmldesigner/componentsplugin/addtabdesigneraction.cpp b/src/plugins/qmldesigner/componentsplugin/addtabdesigneraction.cpp index eff96973bb8..4884d95f617 100644 --- a/src/plugins/qmldesigner/componentsplugin/addtabdesigneraction.cpp +++ b/src/plugins/qmldesigner/componentsplugin/addtabdesigneraction.cpp @@ -77,7 +77,7 @@ int AddTabDesignerAction::priority() const return CustomActionsPriority; } -AbstractDesignerAction::Type AddTabDesignerAction::type() const +ActionInterface::Type AddTabDesignerAction::type() const { return Action; }