diff --git a/src/plugins/git/gerrit/gerritdialog.cpp b/src/plugins/git/gerrit/gerritdialog.cpp index 9f1df2a9aa4..21ccef371a5 100644 --- a/src/plugins/git/gerrit/gerritdialog.cpp +++ b/src/plugins/git/gerrit/gerritdialog.cpp @@ -68,6 +68,7 @@ GerritDialog::GerritDialog(const QSharedPointer &p, m_ui->setupUi(this); m_ui->remoteComboBox->setParameters(m_parameters); + m_ui->remoteComboBox->setFallbackEnabled(true); m_queryModel->setStringList(m_parameters->savedQueries); QCompleter *completer = new QCompleter(this); completer->setModel(m_queryModel); diff --git a/src/plugins/git/gerrit/gerritplugin.cpp b/src/plugins/git/gerrit/gerritplugin.cpp index 2dbf1006195..b9f4fca2015 100644 --- a/src/plugins/git/gerrit/gerritplugin.cpp +++ b/src/plugins/git/gerrit/gerritplugin.cpp @@ -315,7 +315,7 @@ void GerritPlugin::addToLocator(CommandLocator *locator) void GerritPlugin::push(const QString &topLevel) { // QScopedPointer is required to delete the dialog when leaving the function - GerritPushDialog dialog(topLevel, m_reviewers, ICore::mainWindow()); + GerritPushDialog dialog(topLevel, m_reviewers, m_parameters, ICore::mainWindow()); if (!dialog.isValid()) { QMessageBox::warning(ICore::mainWindow(), tr("Initialization Failed"), diff --git a/src/plugins/git/gerrit/gerritpushdialog.cpp b/src/plugins/git/gerrit/gerritpushdialog.cpp index d522bc14912..4f8585b6796 100644 --- a/src/plugins/git/gerrit/gerritpushdialog.cpp +++ b/src/plugins/git/gerrit/gerritpushdialog.cpp @@ -26,6 +26,7 @@ #include "gerritpushdialog.h" #include "ui_gerritpushdialog.h" #include "branchcombobox.h" +#include "gerritserver.h" #include "../gitplugin.h" #include "../gitclient.h" @@ -114,21 +115,11 @@ void GerritPushDialog::initRemoteBranches() BranchDate bd(ref.mid(refBranchIndex + 1), QDateTime::fromTime_t(timeT).date()); m_remoteBranches.insertMulti(ref.left(refBranchIndex), bd); } - QStringList remotes = GitPlugin::client()->synchronousRemotesList(m_workingDir).keys(); - remotes.removeDuplicates(); - { - const QString origin = "origin"; - const QString gerrit = "gerrit"; - if (remotes.removeOne(origin)) - remotes.prepend(origin); - if (remotes.removeOne(gerrit)) - remotes.prepend(gerrit); - } - m_ui->remoteComboBox->addItems(remotes); - m_ui->remoteComboBox->setEnabled(remotes.count() > 1); + m_ui->remoteComboBox->updateRemotes(false); } -GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &reviewerList, QWidget *parent) : +GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &reviewerList, + QSharedPointer parameters, QWidget *parent) : QDialog(parent), m_workingDir(workingDir), m_ui(new Ui::GerritPushDialog) @@ -136,13 +127,15 @@ GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &rev setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint); m_ui->setupUi(this); m_ui->repositoryLabel->setText(QDir::toNativeSeparators(workingDir)); + m_ui->remoteComboBox->setRepository(workingDir); + m_ui->remoteComboBox->setParameters(parameters); PushItemDelegate *delegate = new PushItemDelegate(m_ui->commitView); delegate->setParent(this); initRemoteBranches(); - if (m_ui->remoteComboBox->count() < 1) + if (m_ui->remoteComboBox->isEmpty()) return; m_ui->localBranchComboBox->init(workingDir); @@ -163,8 +156,8 @@ GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &rev m_ui->reviewersLineEdit->setValidator(noSpaceValidator); m_ui->topicLineEdit->setValidator(noSpaceValidator); - connect(m_ui->remoteComboBox, static_cast(&QComboBox::currentIndexChanged), - this, &GerritPushDialog::setRemoteBranches); + connect(m_ui->remoteComboBox, &GerritRemoteChooser::remoteChanged, + this, [this] { setRemoteBranches(); }); m_isValid = true; } @@ -285,10 +278,8 @@ void GerritPushDialog::updateCommits(int index) m_suggestedRemoteBranch = remoteBranch.mid(slash + 1); const QString remote = remoteBranch.left(slash); - const int index = m_ui->remoteComboBox->findText(remote); - if (index != -1 && index != m_ui->remoteComboBox->currentIndex()) - m_ui->remoteComboBox->setCurrentIndex(index); - else + + if (!m_ui->remoteComboBox->setCurrentRemote(remote)) setRemoteBranches(); } validate(); @@ -302,7 +293,7 @@ void GerritPushDialog::validate() QString GerritPushDialog::selectedRemoteName() const { - return m_ui->remoteComboBox->currentText(); + return m_ui->remoteComboBox->currentRemoteName(); } QString GerritPushDialog::selectedRemoteBranchName() const diff --git a/src/plugins/git/gerrit/gerritpushdialog.h b/src/plugins/git/gerrit/gerritpushdialog.h index 723831388fa..c425fd53d88 100644 --- a/src/plugins/git/gerrit/gerritpushdialog.h +++ b/src/plugins/git/gerrit/gerritpushdialog.h @@ -28,6 +28,7 @@ #include #include #include +#include namespace Git { namespace Internal { class GitClient; } @@ -36,6 +37,8 @@ namespace Internal { class GitClient; } namespace Gerrit { namespace Internal { +class GerritParameters; + namespace Ui { class GerritPushDialog; } class GerritPushDialog : public QDialog @@ -43,7 +46,8 @@ class GerritPushDialog : public QDialog Q_OBJECT public: - GerritPushDialog(const QString &workingDir, const QString &reviewerList, QWidget *parent); + GerritPushDialog(const QString &workingDir, const QString &reviewerList, + QSharedPointer parameters, QWidget *parent); ~GerritPushDialog(); QString selectedCommit() const; diff --git a/src/plugins/git/gerrit/gerritpushdialog.ui b/src/plugins/git/gerrit/gerritpushdialog.ui index 6988902d5dc..c392b0a8acf 100644 --- a/src/plugins/git/gerrit/gerritpushdialog.ui +++ b/src/plugins/git/gerrit/gerritpushdialog.ui @@ -6,7 +6,7 @@ 0 0 - 600 + 740 410 @@ -170,7 +170,7 @@ - + @@ -203,6 +203,12 @@ Partial names can be used if they are unambiguous. QComboBox
git/gerrit/branchcombobox.h
+ + Gerrit::Internal::GerritRemoteChooser + QWidget +
git/gerrit/gerritremotechooser.h
+ 1 +
localBranchComboBox diff --git a/src/plugins/git/gerrit/gerritremotechooser.cpp b/src/plugins/git/gerrit/gerritremotechooser.cpp index 0ab8bc1f343..ebb5024932c 100644 --- a/src/plugins/git/gerrit/gerritremotechooser.cpp +++ b/src/plugins/git/gerrit/gerritremotechooser.cpp @@ -51,6 +51,7 @@ GerritRemoteChooser::GerritRemoteChooser(QWidget *parent) : m_remoteComboBox->setMinimumSize(QSize(40, 0)); horizontalLayout->addWidget(m_remoteComboBox); + horizontalLayout->setMargin(0); m_resetRemoteButton = new QToolButton(this); m_resetRemoteButton->setToolTip(tr("Refresh Remote Servers")); @@ -74,6 +75,22 @@ void GerritRemoteChooser::setParameters(QSharedPointer paramet m_parameters = parameters; } +void GerritRemoteChooser::setFallbackEnabled(bool value) +{ + m_enableFallback = value; +} + +bool GerritRemoteChooser::setCurrentRemote(const QString &remoteName) +{ + for (int i = 0, total = m_remoteComboBox->count(); i < total; ++i) { + if (m_remotes[i].first == remoteName) { + m_remoteComboBox->setCurrentIndex(i); + return true; + } + } + return false; +} + bool GerritRemoteChooser::updateRemotes(bool forceReload) { QTC_ASSERT(!m_repository.isEmpty() || !m_parameters, return false); @@ -91,7 +108,9 @@ bool GerritRemoteChooser::updateRemotes(bool forceReload) continue; addRemote(server, mapIt.key()); } - addRemote(m_parameters->server, tr("Fallback")); + if (m_enableFallback) + addRemote(m_parameters->server, tr("Fallback")); + m_remoteComboBox->setEnabled(m_remoteComboBox->count() > 1); m_updatingRemotes = false; handleRemoteChanged(); return true; @@ -116,6 +135,18 @@ GerritServer GerritRemoteChooser::currentServer() const return m_remotes[index].second; } +QString GerritRemoteChooser::currentRemoteName() const +{ + const int index = m_remoteComboBox->currentIndex(); + QTC_ASSERT(index >= 0 && index < int(m_remotes.size()), return QString()); + return m_remotes[index].first; +} + +bool GerritRemoteChooser::isEmpty() const +{ + return m_remotes.empty(); +} + void GerritRemoteChooser::handleRemoteChanged() { if (m_updatingRemotes || m_remotes.empty()) diff --git a/src/plugins/git/gerrit/gerritremotechooser.h b/src/plugins/git/gerrit/gerritremotechooser.h index c69ab9e62a1..c06013bb229 100644 --- a/src/plugins/git/gerrit/gerritremotechooser.h +++ b/src/plugins/git/gerrit/gerritremotechooser.h @@ -47,9 +47,13 @@ public: GerritRemoteChooser(QWidget *parent = nullptr); void setRepository(const QString &repository); void setParameters(QSharedPointer parameters); + void setFallbackEnabled(bool value); + bool setCurrentRemote(const QString &remoteName); bool updateRemotes(bool forceReload); GerritServer currentServer() const; + QString currentRemoteName() const; + bool isEmpty() const; signals: void remoteChanged(); @@ -63,6 +67,7 @@ private: QComboBox *m_remoteComboBox = nullptr; QToolButton *m_resetRemoteButton = nullptr; bool m_updatingRemotes = false; + bool m_enableFallback = false; using NameAndServer = std::pair; std::vector m_remotes; };