From 9e995fe80155021ea92917063343f4dcb4b928d0 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Thu, 10 Apr 2025 18:36:34 +0200 Subject: [PATCH] QmlDesigner: Optimize condition isBasedOn() handles equality. This already handles equality of types. Change-Id: If03e083ff6e3446341a37b8fd8fd8978bfc20666 Reviewed-by: Marco Bubke --- .../qmldesigner/components/bindingeditor/bindingeditor.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp b/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp index 2a066343ca6..a62f507b943 100644 --- a/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp +++ b/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp @@ -177,10 +177,8 @@ bool isType(const TypeName &first, const TypeName &second, const Tuple &...types bool compareTypes(const NodeMetaInfo &sourceType, const NodeMetaInfo &targetType) { #ifdef QDS_USE_PROJECTSTORAGE - return targetType.isVariant() || sourceType.isVariant() || targetType == sourceType - || (targetType.isNumber() && sourceType.isNumber()) - || (targetType.isColor() && sourceType.isColor()) - || (targetType.isString() && sourceType.isString()); + return targetType.isVariant() || sourceType.isVariant() + || (targetType.isNumber() && sourceType.isNumber()) || sourceType.isBasedOn(targetType); #else const TypeName source = sourceType.simplifiedTypeName(); const TypeName target = targetType.simplifiedTypeName();