From 9e9bd383bcb3e9b0569671ed06a49cd2103ac6ae Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Thu, 6 May 2021 16:42:02 +0200 Subject: [PATCH] FileUtils: Simplify statement Change-Id: I9db62241c81c2ffc25c2caa34524e4c98ef01ed1 Reviewed-by: Eike Ziller --- src/libs/utils/fileutils.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/libs/utils/fileutils.cpp b/src/libs/utils/fileutils.cpp index fd61b52ab1d..0f8757a90c9 100644 --- a/src/libs/utils/fileutils.cpp +++ b/src/libs/utils/fileutils.cpp @@ -654,12 +654,10 @@ FileSaver::FileSaver(const QString &filename, QIODevice::OpenMode mode) "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9", "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9"}; const QString fn = QFileInfo(filename).baseName().toUpper(); - for (const QString &rn : reservedNames) { - if (fn == rn) { - m_errorString = tr("%1: Is a reserved filename on Windows. Cannot save.").arg(filename); - m_hasError = true; - return; - } + if (reservedNames.contains(fn)) { + m_errorString = tr("%1: Is a reserved filename on Windows. Cannot save.").arg(filename); + m_hasError = true; + return; } } if (mode & (QIODevice::ReadOnly | QIODevice::Append)) {