From 9ec332afdd6c70fdeb41d48052efa88e4cbc84e8 Mon Sep 17 00:00:00 2001 From: Nikita Baryshnikov Date: Tue, 26 May 2015 17:19:38 +0300 Subject: [PATCH] BaseFileFilter: export Iterator and deinline dtor. It saves 1 copy. Similar to 184695be925abe77f5182698c0d000c2b2589534 Change-Id: I2a55b00aa65bc3d0ac7f45d7321ea099882c776e Reviewed-by: Daniel Teske Reviewed-by: Eike Ziller --- src/plugins/coreplugin/locator/basefilefilter.cpp | 3 +++ src/plugins/coreplugin/locator/basefilefilter.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/plugins/coreplugin/locator/basefilefilter.cpp b/src/plugins/coreplugin/locator/basefilefilter.cpp index 8f28191433b..b505ccfaad6 100644 --- a/src/plugins/coreplugin/locator/basefilefilter.cpp +++ b/src/plugins/coreplugin/locator/basefilefilter.cpp @@ -72,6 +72,9 @@ public: } // Internal } // Core +BaseFileFilter::Iterator::~Iterator() +{} + BaseFileFilter::BaseFileFilter() : d(new Internal::BaseFileFilterPrivate) { diff --git a/src/plugins/coreplugin/locator/basefilefilter.h b/src/plugins/coreplugin/locator/basefilefilter.h index fefc6a1d39a..ad7d49c0a13 100644 --- a/src/plugins/coreplugin/locator/basefilefilter.h +++ b/src/plugins/coreplugin/locator/basefilefilter.h @@ -45,9 +45,9 @@ class CORE_EXPORT BaseFileFilter : public ILocatorFilter Q_OBJECT public: - class Iterator { + class CORE_EXPORT Iterator { public: - virtual ~Iterator() { } + virtual ~Iterator(); virtual void toFront() = 0; virtual bool hasNext() const = 0; virtual QString next() = 0;