feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix link on commit sha in about dialog

Browse Source 
Passing a URL via defines breaks when trying to "stringify" it.
It would always stop at the first slash.
Instead use a qmake variable directly. That has the additional advantage that
the value isn't passed on each and every compiler command line.

Change-Id: I97a297fbcdee5ea03eb6fa08181c95b1ad2de767
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Eike Ziller
2020-03-19 16:02:44 +01:00
parent 549b2f6092
commit 9eceb46739
6 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/coreplugin/versiondialog.cpp
View File

@@ -57,8 +57,7 @@ VersionDialog::VersionDialog(QWidget *parent)
QString ideRev;
#ifdef IDE_REVISION
//: This gets conditionally inserted as argument %8 into the description string.
const QString revUrl = QString::fromLatin1(Constants::IDE_REVISION_URL_STR);
const QString revUrl = QString::fromLatin1(Constants::IDE_REVISION_URL);
const QString rev = QString::fromLatin1(Constants::IDE_REVISION_STR).left(10);
ideRev = tr("<br/>From revision %1<br/>")
.arg(revUrl.isEmpty() ? rev