feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Revert "QmlJSCheck: Ensure that ::createObjectsForImport always works correctly"

Browse Source 
This reverts commit fa376883f0.

Reverting because this patch causes code model reset to fail often,
leading to corruption of code model.

Fixes: QDS-11496
Fixes: QDS-11520
Change-Id: Ied04dc34ef9f51e535dfe0772e245bdcb78e908a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
(cherry picked from commit cca73bb927)
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Miikka Heikkinen
2024-06-11 15:09:49 +03:00
committed by Tim Jenssen
parent e9de4e0805
commit 9ef82deb62
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/qmljs/qmljsinterpreter.cpp
View File

@@ -1493,10 +1493,8 @@ QList<const CppComponentValue *> CppQmlTypes::createObjectsForImport(const QStri
// if it already exists, skip // if it already exists, skip
const QString key = qualifiedName(package, fmo->className(), version); const QString key = qualifiedName(package, fmo->className(), version);
if (m_objectsByQualifiedName.contains(key)) { if (m_objectsByQualifiedName.contains(key))
exportedObjects.insert(key, m_objectsByQualifiedName.value(key));
continue; continue;
}
ComponentVersion cppVersion; ComponentVersion cppVersion;
for (const FakeMetaObject::Export &bestExport : std::as_const(bestExports)) { for (const FakeMetaObject::Export &bestExport : std::as_const(bestExports)) {