feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Change total time and recursion display in statistics

Browse Source 
The total time taken for a program should be the sum of durations of
events on the bottom of the stack. This is also what the flame graph
model does, and it results in useful percentages for total and self
times.

Recursion still has to be accounted for when showing the total time of
a specific event type, but we mark events with recursive calls and
show the time and percentage of recursion in the tooltip. As we already
showed binding loops on bindings and signal handlers before, this
integrates nicely.

Change-Id: Id4654e314bf86ce8bd06ceaaf93a67187c629adc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Ulf Hermann
2016-12-28 18:12:49 +01:00
parent 548a86f577
commit 9f0a51a0d1
3 changed files with 63 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/plugins/qmlprofiler/qmlprofilerstatisticsview.cpp
View File

@@ -233,7 +233,7 @@ QString QmlProfilerStatisticsView::summary(const QVector<int> &typeIds) const
double sum = 0;
for (int typeId : typeIds) {
const double percentage = d->model->getData()[typeId].percentOfTime;
const double percentage = d->model->durationPercent(typeId);
if (percentage > maximum)
maximum = percentage;
sum += percentage;
@@ -268,7 +268,7 @@ QStringList QmlProfilerStatisticsView::details(int typeId) const
return QStringList({
QmlProfilerStatisticsMainView::nameForType(type.rangeType()),
data,
QString::number(d->model->getData()[typeId].percentOfTime, 'f', 2) + QLatin1Char('%')
QString::number(d->model->durationPercent(typeId), 'f', 2) + QLatin1Char('%')
});
}
@@ -576,9 +576,11 @@ void QmlProfilerStatisticsMainView::updateNotes(int typeIndex)
if (it != noteList.end()) {
item->setBackground(colors()->noteBackground);
item->setToolTip(it.value());
} else if (stats.isBindingLoop) {
} else if (stats.durationRecursive > 0) {
item->setBackground(colors()->noteBackground);
item->setToolTip(tr("Binding loop detected."));
item->setToolTip(tr("%1 / %2% of total in recursive calls")
.arg(Timeline::formatTime(stats.durationRecursive))
.arg(stats.durationRecursive * 100l / stats.duration));
} else if (!item->toolTip().isEmpty()){
item->setBackground(colors()->defaultBackground);
item->setToolTip(QString());
@@ -611,8 +613,9 @@ void QmlProfilerStatisticsMainView::parseModel()
}
if (d->m_fieldShown[TimeInPercent]) {
newRow << new StatisticsViewItem(QString::number(stats.percentOfTime, 'f', 2)
+ QLatin1String(" %"), stats.percentOfTime);
const double percent = d->model->durationPercent(typeIndex);
newRow << new StatisticsViewItem(QString::number(percent, 'f', 2)
+ QLatin1String(" %"), percent);
}
if (d->m_fieldShown[TotalTime]) {
@@ -621,8 +624,9 @@ void QmlProfilerStatisticsMainView::parseModel()
}
if (d->m_fieldShown[SelfTimeInPercent]) {
newRow << new StatisticsViewItem(QString::number(stats.percentSelf, 'f', 2)
+ QLatin1String(" %"), stats.percentSelf);
const double percentSelf = d->model->durationSelfPercent(typeIndex);
newRow << new StatisticsViewItem(QString::number(percentSelf, 'f', 2)
+ QLatin1String(" %"), percentSelf);
}
if (d->m_fieldShown[SelfTime]) {
@@ -634,8 +638,9 @@ void QmlProfilerStatisticsMainView::parseModel()
newRow << new StatisticsViewItem(QString::number(stats.calls), stats.calls);
if (d->m_fieldShown[TimePerCall]) {
newRow << new StatisticsViewItem(Timeline::formatTime(stats.timePerCall),
stats.timePerCall);
const qint64 timePerCall = stats.duration / stats.calls;
newRow << new StatisticsViewItem(Timeline::formatTime(timePerCall),
timePerCall);
}
if (d->m_fieldShown[MedianTime]) {
@@ -909,10 +914,10 @@ void QmlProfilerStatisticsRelativesView::rebuildTree(
newRow.at(3)->setData(stats.calls);
newRow.at(4)->setData(type.data());
if (stats.isBindingLoop) {
if (stats.isRecursive) {
foreach (QStandardItem *item, newRow) {
item->setBackground(colors()->noteBackground);
item->setToolTip(tr("Part of binding loop."));
item->setToolTip(tr("called recursively"));
}
}