feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

re-enable $$system() processing

Browse Source 
unlike the conditional variant, the substituting variant may actually
provide interesting output with rather low likelyhood of side effects.
btw, my FIXME was bogus - i confused the two variants.
This commit is contained in:
Oswald Buddenhagen
2009-03-02 19:58:54 +01:00
parent f6e304f09d
commit 9f51e3b72c
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared/proparser/profileevaluator.cpp
View File

@@ -1447,11 +1447,8 @@ QStringList ProFileEvaluator::Private::evaluateExpandFunction(const QString &fun
ret += val; ret += val;
} }
break; break;
#if 0 // Disabled, as it is relatively useless, too slow and dangerous.
case E_SYSTEM: case E_SYSTEM:
if (!m_skipLevel) { // FIXME: should exec only if the result is being used if (!m_skipLevel) {
// (i.e., if this is nested into an assignment) - these
// are less likely to have side effects
if (args.count() < 1 || args.count() > 2) { if (args.count() < 1 || args.count() > 2) {
q->logMessage(format("system(execute) requires one or two arguments.")); q->logMessage(format("system(execute) requires one or two arguments."));
} else { } else {
@@ -1476,7 +1473,6 @@ QStringList ProFileEvaluator::Private::evaluateExpandFunction(const QString &fun
} }
} }
break; break;
#endif
case E_UNIQUE: case E_UNIQUE:
if(args.count() != 1) { if(args.count() != 1) {
q->logMessage(format("unique(var) requires one argument.")); q->logMessage(format("unique(var) requires one argument."));