From 9fcd388c9b488ce29cf281e3ebc7b274e4944000 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 3 Jul 2024 17:27:53 +0200 Subject: [PATCH] QmlDesigner: Remove ineffective code IContext::context() returns a copy by value. Adding to that does not change IContext's internal m_context, i.e. these lines are effectively no-ops. Assuming that it currently "works", the setup probably happens elsewhere, and this code is superfluous. Change-Id: Idf33c769eed98bfa34a6def7649c8280f1551716 Reviewed-by: Eike Ziller (cherry picked from commit 756e4dbb245ff6be54acfcd61f7d2084c9914f67) Reviewed-by: Tim Jenssen --- src/plugins/qmldesigner/qmldesignerplugin.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/plugins/qmldesigner/qmldesignerplugin.cpp b/src/plugins/qmldesigner/qmldesignerplugin.cpp index d2f221e746a..ca2b5cd46f3 100644 --- a/src/plugins/qmldesigner/qmldesignerplugin.cpp +++ b/src/plugins/qmldesigner/qmldesignerplugin.cpp @@ -391,14 +391,6 @@ void QmlDesignerPlugin::integrateIntoQtCreator(QWidget *modeWidget) Core::Context qmlDesignerMaterialBrowserContext(Constants::C_QMLMATERIALBROWSER); Core::Context qmlDesignerAssetsLibraryContext(Constants::C_QMLASSETSLIBRARY); - context->context().add(qmlDesignerMainContext); - context->context().add(qmlDesignerFormEditorContext); - context->context().add(qmlDesignerEditor3dContext); - context->context().add(qmlDesignerNavigatorContext); - context->context().add(qmlDesignerMaterialBrowserContext); - context->context().add(qmlDesignerAssetsLibraryContext); - context->context().add(ProjectExplorer::Constants::QMLJS_LANGUAGE_ID); - d->shortCutManager.registerActions(qmlDesignerMainContext, qmlDesignerFormEditorContext, qmlDesignerEditor3dContext, qmlDesignerNavigatorContext);