feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Fix a warning

Browse Source 
Code is technically correct, but gcc 13.2.0 complains:
toolchain.cpp:925:295: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
  925 |         if (__builtin_expect(!!(factory()->supportedLanguages().contains(tc->language())), true)) {} else { ::Utils::writeAssertLocation( "\"" "factory()->supportedLanguages().contains(tc->language())""\" in " "/data/dev/creator/src/plugins/projectexplorer/toolchain.cpp" ":" "925"); return; } do {} while (0);

Change-Id: I37bb34917fc06e51a2d40807d9f4a26447880b81
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2024-10-22 12:28:46 +02:00
parent 7a56d615df
commit a044dd4a08
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/toolchain.cpp
View File

@@ -921,8 +921,9 @@ ToolchainBundle::ToolchainBundle(const Toolchains &toolchains, AutoRegister auto
// Check pre-conditions. // Check pre-conditions.
QTC_ASSERT(!m_toolchains.isEmpty(), return); QTC_ASSERT(!m_toolchains.isEmpty(), return);
QTC_ASSERT(m_toolchains.size() <= factory()->supportedLanguages().size(), return); QTC_ASSERT(m_toolchains.size() <= factory()->supportedLanguages().size(), return);
for (const Toolchain * const tc : toolchains) for (const Toolchain * const tc : toolchains) {
QTC_ASSERT(factory()->supportedLanguages().contains(tc->language()), return); QTC_ASSERT(factory()->supportedLanguages().contains(tc->language()), return);
}
for (int i = 1; i < int(toolchains.size()); ++i) { for (int i = 1; i < int(toolchains.size()); ++i) {
const Toolchain * const tc = toolchains.at(i); const Toolchain * const tc = toolchains.at(i);
QTC_ASSERT(tc->typeId() == toolchains.first()->typeId(), return); QTC_ASSERT(tc->typeId() == toolchains.first()->typeId(), return);