feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Start unifing visual appearance of run config widgets

Browse Source 
Margins and layout style widely differ so far. Start moving everything
to a QFormLayout with the same margin and growth policy.

Change-Id: I0bd1d8b2ec9830be56354be1376a2a24eebb8845
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-04-06 17:23:06 +02:00
parent c66f52c065
commit a06514c365
6 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
View File

@@ -54,8 +54,6 @@ public:
CMakeRunConfigurationWidget(RunConfiguration *rc)
{
auto fl = new QFormLayout(this);
fl->setMargin(0);
fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
rc->extraAspect<ExecutableAspect>()->addToMainConfigurationWidget(this, fl);
rc->extraAspect<ArgumentsAspect>()->addToMainConfigurationWidget(this, fl);

5
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -48,6 +48,7 @@
#include <coreplugin/icore.h>
#include <QDir>
#include <QFormLayout>
#include <QPushButton>
#include <QTimer>
#include <QLoggingCategory>
@@ -304,6 +305,10 @@ QWidget *RunConfiguration::wrapWidget(QWidget *inner) const
auto detailsWidget = new Utils::DetailsWidget;
detailsWidget->setState(DetailsWidget::NoSummary);
detailsWidget->setWidget(inner);
if (auto fl = qobject_cast<QFormLayout *>(inner->layout())){
fl->setMargin(0);
fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
}
return detailsWidget;
}

2
src/plugins/pythoneditor/pythoneditorplugin.cpp
View File

@@ -331,8 +331,6 @@ PythonRunConfigurationWidget::PythonRunConfigurationWidget(PythonRunConfiguratio
: m_runConfiguration(runConfiguration)
{
auto fl = new QFormLayout(this);
fl->setMargin(0);
fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
auto interpreterChooser = new FancyLineEdit(this);
interpreterChooser->setText(runConfiguration->interpreter());

2
src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp
View File

@@ -64,8 +64,6 @@ public:
explicit QbsRunConfigurationWidget(QbsRunConfiguration *rc)
{
auto toplayout = new QFormLayout(this);
toplayout->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
toplayout->setMargin(0);
rc->extraAspect<ExecutableAspect>()->addToMainConfigurationWidget(this, toplayout);
rc->extraAspect<ArgumentsAspect>()->addToMainConfigurationWidget(this, toplayout);

2
src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp
View File

@@ -115,8 +115,6 @@ DesktopQmakeRunConfigurationWidget::DesktopQmakeRunConfigurationWidget(DesktopQm
: m_qmakeRunConfiguration(qmakeRunConfiguration)
{
auto toplayout = new QFormLayout(this);
toplayout->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
toplayout->setMargin(0);
m_qmakeRunConfiguration->extraAspect<ExecutableAspect>()->addToMainConfigurationWidget(this, toplayout);
m_qmakeRunConfiguration->extraAspect<ArgumentsAspect>()->addToMainConfigurationWidget(this, toplayout);

1
src/plugins/qmlprojectmanager/qmlprojectrunconfigurationwidget.cpp
View File

@@ -51,7 +51,6 @@ QmlProjectRunConfigurationWidget::QmlProjectRunConfigurationWidget(QmlProjectRun
m_fileListModel(new QStandardItemModel(this))
{
auto form = new QFormLayout(this);
form->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
m_fileListCombo = new QComboBox;
m_fileListCombo->setModel(m_fileListModel);